MachineNameTest::testMachineName () has problem with 3 and more test values [#2844193]

When \Drupal\FunctionalJavascriptTests\Core\MachineNameTest::testMachineName has 3 values for testing, than the third test uses result of the second test.

Comment	File	Size	Author
#4	2844193-4.patch	905 bytes	Anonymous (not verified)
#4	8.3.x: PHP 5.6 & MySQL 5.5 21,428 pass
#4	demo_with_3_caces_2844193-4.patch	1.34 KB	Anonymous (not verified)
#4	8.3.x: PHP 5.6 & MySQL 5.5 21,428 pass
#2	2844193-2-test-only.patch	802 bytes	Anonymous (not verified)
#2	8.3.x: PHP 5.6 & MySQL 5.5 21,426 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 17 January 2017 at 11:45

vaplas created an issue. See original summary.

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 17 January 2017 at 11:46

Status:

Active

» Needs review

File	Size
2844193-2-test-only.patch	802 bytes
8.3.x: PHP 5.6 & MySQL 5.5 21,426 pass, 1 fail

Comment #3

17 January 2017 at 14:40

Status:

Needs review

» Needs work

The last submitted patch, 2: 2844193-2-test-only.patch, failed testing.

Comment #4

Anonymous (not verified) CreditAttribution: Anonymous commented 17 January 2017 at 18:07

Category:	Bug report	» Task
Status:	Needs work	» Needs review

File	Size
demo_with_3_caces_2844193-4.patch	1.34 KB
8.3.x: PHP 5.6 & MySQL 5.5 21,428 pass
2844193-4.patch	905 bytes
8.3.x: PHP 5.6 & MySQL 5.5 21,428 pass

OK. Maybe it's not a bug, but refactoring task. Last line with $this->assertEquals($test_values[1]['expected'] looks fishily.

Comment #5

17 January 2017 at 18:07

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.