Problem/Motivation

The Drupal 7.50 included a new permission 'administer fields' that is now required to make any changes to fields attached to node bundles. The tests for Link are now failing because this new permission is not assigned to its test users.

Issue that introduced the new permission: #611294: Refine permissions for Field UI
Related change record: https://www.drupal.org/node/2483307

Proposed resolution

Fix the failing tests by assigning the 'administer fields' permission to the test users.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 link-fix_tests_administer_fields-2843813-2.patch8.69 KBidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Active » Needs review
FileSize
link-fix_tests_administer_fields-2843813-2.patch8.69 KB

Attached patch adds the new 'administer fields' permission to the administrative users in the link tests, so the tests are no longer failing.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi at jobiqo - job board technology commented
Status: Needs review » Reviewed & tested by the community

Makes sense, thanks!

michael_wojcik’s picture

michael_wojcik CreditAttribution: michael_wojcik as a volunteer and at Mediacurrent for Georgia Institute of Technology commented
Priority: Normal » Critical

Tested this patch successfully locally. All Simpletest automated tests included in the Link module pass successfully as expected with the patch, after failing without the patch. +1 RTBC.

I'm escalating this issue to Critical priority, because this issue appears to be actively blocking all further work on all other issues on the Link project, due to all automated test runs failing for any new patches uploaded to any issues. Basing this decision on the priority documentation here: https://www.drupal.org/node/45111.

Is it possible to release this patch in a hotfix release for the project, due to the severe impact of this issue on the rest of the project? That is, can there be a new project release for just this fix alone, maybe tagged as something like 7.x-1.4.1?

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom as a volunteer commented

Please commit :)

  • idebr authored 351670d on 7.x-1.x 
    Issue #2843813 by idebr, klausi, michael_wojcik, clemens.tolboom: Fix...
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom as a volunteer commented
Status: Reviewed & tested by the community » Fixed

I'm now a co-maintainer so hope to fix some more issues.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom as a volunteer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.