Default is to display favorites in the user overview.

Is it possible to display those into a new tab (e.g. a MENU_LOCAL_TASK) ?
This things could be configurable via the administration interface.

If you don't have time, I propose mine to do it.

I'm not doing it right now because I don't need this now. But in some weeks, I won't have the choice to do it, I'll do It, please tell me if you are interested to add and maintain such a feature if I develop it.

CommentFileSizeAuthor
#4 favorite_nodes-5.x-1.2-view_as_local_task-v2.patch8.61 KBpounard
#1 favorite_nodes.module-5.x-1.2-view_as_local_task.patch7.37 KBpounard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented
Status: Active » Needs review
FileSize
favorite_nodes.module-5.x-1.2-view_as_local_task.patch7.37 KB

And I did it, and fixed 2 minor bugs too.

See the patch file here.

I wait for some activity from mainteners, if this patch is good to you, would be great to put it in HEAD :)

kbahey’s picture

kbahey CreditAttribution: kbahey commented
Version: 5.x-1.2 » 5.x-1.x-dev
Status: Needs review » Patch (to be ported)

Thank you for the patch. It is committed to the 5.x dev version.

Would be nice to have this ported to Drupal 6.

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented

I don't have much time to port it to Drupal 6, if my needs lead to this one day, I'll do it.

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented
FileSize
favorite_nodes-5.x-1.2-view_as_local_task-v2.patch8.61 KB

I made some bugfix (my errors) and added a feature which permit the administrator to hide empty categories in user favorite listing (working).

This a minor patch, I think it dont deserve intensive test, but I should test and integrate this also if you like.

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented
Status: Patch (to be ported) » Needs review
kbahey’s picture

kbahey CreditAttribution: kbahey commented
Status: Needs review » Needs work

Lots of failures. Are you sure this is against the current version of the DRUPAL-5 tag in cvs?

patching file favorite_nodes.module
Hunk #1 succeeded at 12 with fuzz 2.
Hunk #2 FAILED at 37.
Hunk #3 FAILED at 63.
Hunk #4 FAILED at 80.
Hunk #5 succeeded at 109 with fuzz 2 (offset 15 lines).
Hunk #6 FAILED at 140.
Hunk #7 FAILED at 154.
Hunk #8 FAILED at 201.
Hunk #9 succeeded at 352 with fuzz 2 (offset 29 lines).
Hunk #10 succeeded at 374 (offset 29 lines).
Hunk #11 FAILED at 432.
Hunk #12 FAILED at 482.
Hunk #13 FAILED at 551.
Hunk #14 FAILED at 582.
Hunk #15 FAILED at 606.
11 out of 15 hunks FAILED -- saving rejects to file favorite_nodes.module.rej

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented

I put the version on which I did the patch in filename (5.x-1.2).
I can do it on current head version, but I have much work so I wont be able to do it for a few days.