On the domain batch updating page (/admin/structure/domain/batch) you get this notice: Notice: Undefined index: #module in domain_batch_sort() (line 763 of <dvg modules dir>/domain/domain.admin.inc).

This causes the actions that fall in the "other" category because they lack a module to get improperly sorted at the top without being placed in the "other" subsection (that due to this bug also doesn't exist).

CommentFileSizeAuthor
#2 domain-batch-updating-sorting-2842457-2.patch416 bytespaulvandenburg

Comments

pburg created an issue. See original summary.

paulvandenburg’s picture

paulvandenburg commented
StatusFileSize
new domain-batch-updating-sorting-2842457-2.patch416 bytes

The problem lies in the function domain_batch_list(). It loops through all action options and tries to add the "other" #module type to all options that lack that field. However instead of modifying the array using a reference, it only modifies the local variable that is gone after the foreach ends.

This simple fix properly sets the "other" category so the sorting can freely do its thing.

paulvandenburg’s picture

paulvandenburg commented
Status: Active » Needs review
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community

  • agentrickard committed 79754df on 7.x-3.x 
    Issue #2842457 by pburg: Domains Batch updating sort improperly handles...
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Reviewed & tested by the community » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented