1. Go to https://www.drupal.org/node/1344774/git-instructions/8.x-1.x
  2. Scroll to the bottom of the page to see "Tag for a stable release" examples
  3. Notice that all examples are for 7.x-1.x

Fix: Update examples to 8.x-1.x:

git checkout  8.x-1.x
git tag 8.x-1.0
git push origin tag 8.x-1.0
CommentFileSizeAuthor
#4 don_t_hardcode_values-2841367-4.patch3.45 KBhelmo
#2 do-not-hardcode-new-branch-and-new-tag-2841367-2.patch2.85 KBao2

Comments

wmostrey created an issue. See original summary.

ao2’s picture

ao2 commented
Title: Instructions for 8.x-1.x show "Tag for a stable release" for 7.x-1.x » Don't hardcode values for new branch and new tag
Status: Active » Needs review
StatusFileSize
new do-not-hardcode-new-branch-and-new-tag-2841367-2.patch2.85 KB

The issue shows up in the "Creating Releases" section, so only maintainers of the given project experience it.

I cannot see the "Creating Releases" in the link provided by the OP, but I can see that section in the git-instruction page for my own projects, and the suggested tag is indeed wrong.

After giving a glance at the code I see that there are some hardcoded values for the branch and tag.

The attached patch should improve the situation, but obviously I cannot test it.

Thanks,
Antonio

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented

The first visual check looks good.

I have a new D.o dev site to work on, so I'll test it there and make any further changes, if needed.

Thanks!

helmo’s picture

helmo commented
StatusFileSize
new don_t_hardcode_values-2841367-4.patch3.45 KB

Thanks, looks good.
This new patch also updates the 'Example replacement values' in the admin settings form.

ao2’s picture

ao2 commented

Ping. Can we tag this RTBC?

  • helmo committed 7319239 on 7.x-1.x 
    Issue #2841367 by ao2, helmo: Don't hardcode values for new branch and...
helmo’s picture

helmo commented
Status: Needs review » Reviewed & tested by the community

I suppose so. I'll commit.

helmo’s picture

helmo commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +needs drupal.org deployment

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

drumm’s picture

drumm
he/him
Location NY, US
commented
Issue tags: -needs drupal.org deployment

This was deployed a few days ago.