Custom label for Title (D8 edition)

This should do it. I'm not 100% sure why "title" was being unset for overrides in eck_entity_bundle_field_info_alter, but I got rid of it to make this patch to work. Hopefully the maintainers have some input here.

May just need a little bit of cleanup and some tests.

The code looks good to me besides the comment below. However I would like to see tests for this functionality.

+++ b/src/Form/EntityBundle/EckEntityBundleForm.php
@@ -90,6 +101,27 @@ class EckEntityBundleForm extends EntityForm {
+        $title = $field === 'uid' ? 'author' : $field;

Doesn't the field definition have a label we can use for this?

Forgot to set to needs work.

Fixed the issue brought up about the field labels. Note that I stole that original code from EckEntityTypeFormBase if you want to update it there too.

Still needs tests.

Changes:

• Ported to the latest -dev
• Empty value means that the default label should be used
• No label overriding fieldset in entity type form If no base field present in the entity type
• Some CS in affected files fixed

Note that to translate the overridden labels via UI the core bug #2869124: Base field overrides cannot be translated which renders some entity form labels untranslatable must be fixed.

Waiting for some feedback before adding tests.