Closed (fixed)
Project:
Field Permissions
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Dec 2016 at 15:50 UTC
Updated:
17 Jan 2017 at 21:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hypertext200Comment #3
jhedstromThanks for working on this! Just a few small changes/fixes here I think:
Both the file name and the class name are missing an 'n' in FieldPermissioSettings.
Coding standards nit here. There should be spaces in the switch bit, and indentation under each case.
Also, can you use the class constants here for the values (such as
FieldPermissionTypeInterface::ACCESS_CUSTOM)?Comment #4
hypertext200Thanks @jhedstrom for pointing me out those issues. I fixed those and recreated the patch and attached here.
Comment #6
jhedstromThanks! Committed to 8.x!