clarify 'insert' in hook_nodeapi [#283931]

It would be useful to clarify that the 'insert' operation is called *after* the node has been added to the database -- in other words, altering $node here has no effect.

ie, change:

"insert": The node is being created (inserted in the database).

"insert": The node has just been created (inserted in the database).

Comment	File	Size	Author
#5	283931-hook_nodeapi_insert.diff	598 bytes	jeffschuler
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

eikes CreditAttribution: eikes commented 23 July 2008 at 14:05

i second that!

Comment #3

threexk CreditAttribution: threexk commented 6 January 2009 at 19:01

agree

Comment #4

jeffschuler

Boulder, Colorado

CreditAttribution: jeffschuler commented 7 March 2009 at 19:54

Assigned:

Unassigned

» jeffschuler

Comment #5

jeffschuler

Boulder, Colorado

CreditAttribution: jeffschuler commented 7 March 2009 at 20:08

Status:

Active

» Needs review

File	Size
283931-hook_nodeapi_insert.diff	598 bytes

Patch to change inline description of hook_nodeapi_insert to:

Respond to node insertion.
Take action when a new node of any type is being inserted in the database.

Looks like there are a number of ways of describing a hook that operates after something happens: "allow modules to interact with...", "Respond to...", "Act on..." (see node.api.php functions.) I'm not sure what the best wording is, but maybe these should be made more consistent...?