The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
From #2834253: Missing column headings in Revisions list, the button "Compare" at the end of the form is self-explaining. We could try to improve it to "Compare selection".
Proposed resolution
Change tests and value of the button.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | compare-selected-revisions.png | 28.07 KB | ginovski |
| #4 | improve_compare_button-2838915-4.patch | 15.48 KB | ginovski |
| #2 | improve_compare_button-2838915-2.patch | 14.57 KB | ginovski |
Comments
Comment #2
ginovski commentedRenamed to Compare selection.
Comment #3
miro_dietikerAdmin content at admin/content uses the button label "Apply to selected items".
Funnily, admin/content/comment uses a completely different representation for bulk operations...
A last try to search for similarities: admin/modules shows "Install" on the button, to install the selected modules.
This issue proposes a 4th pattern that differs from all.
Just "Compare" as it is not is at least similar to the install page.
If like content, then "Compare selected items" or i'd prefer to adapt it to "Compare selected revisions".
Yes i'm also not a fan of spending a word more, but it seems we need to tell what we are comparing.
One thing though from though that caught my eye is: Our Compare button (whatever its label is) should be the primary operation, being a blue button!
Comment #4
ginovski commented1. Changed button label to 'Compare selected revisions' and set it as primary.
2. Changed tests accordingly.
There might be some fails in DiffViewModeTest, I think they are unrelated to this issue.
Edit: They were only local fails.
Comment #5
ginovski commentedCurrent form with the primary button screenshot:
Comment #6
johnchqueLooks good!
Comment #8
miro_dietikerCommitted, thx.