Modal Form Example not working

OK, that behavior is just *wrong*. I'm not even seeing a modal form, which should "pop up" from the page.

Let me see what's up with this.

Now I'm understanding better. Notice that there's no link to "examples/fapi-example/modal-form"; you had to navigate there yourself. There's a route for it, but you access the example via the link on the "examples/fapi-example" page. Click the "Modal Example" link and you see this:

So the example works; it just isn't clear that this is how you access it.

The link is magic:

<a href="/examples/fapi-example/modal-form" class="use-ajax" data-dialog-type="modal">Modal Example</a>

The Javascript recognizes the class and the data-dialog-type attribute to link it to the page at the href.

This needs to be explained. It wasn't obvious to you. It wasn't obvious to me either. I think that the target page you accessed needs to be modified to work as a demonstration to supplement that one link.

I filed #2883725: fapi_example modal dialog does not show result message w/ JS which I'll mark as duplicate.

There's also this issue dealing with the submit handler: #2870746: Add JS functional tests for modal example, including validation phase

OK, so the ajax submit handler was waaaaay wrong. :-)

This patch gives us the option of showing the input form on the page, or as a dialog, with a link to the dialog if the user wants to see it.

It still suffers from the validation error seen in #2870746: Add JS functional tests for modal example, including validation phase but we'll fix that there, and add JS functional tests there too.

It's a toss-up whether this should be in the fapi example or ajax example.

OK. Now we have the behavior we want, let's fix validation and add tests: [#2870746

Thanks everyone!