The $library['error message'] variable isn't populated so an error is thrown. Patch attached should fix this.

CommentFileSizeAuthor
#10 2837133-fixes-language-form-error.patch2.09 KByukare
#8 2837133-fixes-language-form-error.patch2.12 KByukare
#2 2837133-1-fixes-language-form-error.patch1.55 KBadammalone

Comments

typhonius created an issue. See original summary.

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Status: Active » Needs review
StatusFileSize
new 2837133-1-fixes-language-form-error.patch1.55 KB

Attaching patch.

yukare’s picture

yukare commented

If it pass on bot i will commit it, sorry by not working on this before.

yukare’s picture

yukare commented
Status: Needs review » Needs work

Have to change for bot, i think.

yukare’s picture

yukare commented
Status: Needs work » Needs review

And now it go.

Status: Needs review » Needs work

The last submitted patch, 2: 2837133-1-fixes-language-form-error.patch, failed testing.

yukare’s picture

yukare commented

This path need works. I did some changes to this part of code, so now we can use composer, but the same error can occur, and now in some more places.

It does not occur on test bot because it always install the geshi library with composer.

yukare’s picture

yukare commented
Status: Needs work » Needs review
StatusFileSize
new 2837133-fixes-language-form-error.patch2.12 KB

I did a new patch, it show the same message and show a link to readme.txt where there is new install instructions, please review it.

Status: Needs review » Needs work

The last submitted patch, 8: 2837133-fixes-language-form-error.patch, failed testing.

yukare’s picture

yukare commented
Status: Needs work » Needs review
StatusFileSize
new 2837133-fixes-language-form-error.patch2.09 KB

One patch with coding standards break this one, trying again with a new version.

  • yukare authored 71cc848 on 8.x-1.x 
    Issue #2837133 by yukare, typhonius: Language settings form errors when...
yukare’s picture

yukare commented
Status: Needs review » Fixed

Fixed with this commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.