"Browse available tokens." link missing from Configure block dialogue

I came here to post a patch for the same issue.
Let's get it fixed!

Did you assign to yourself because you're working on a patch?
Otherwise, you should unassign to indicate that it's ready to be picked up by anybody.

He did, but he also left for the weekend already. If you have a patch, post it.

ok, here it is

That's... an interesting use of #description.

Can you post a screenshot of how that looks?

Also needs tests

I was surprised that this worked at all:

The 'browse' link is appended to div.description

The problem with a more standard approach is that "Title" field doesn't have a #weight during form_alter, so it's not straightforward to situate a new element between the first 2 fields.
This approach was more expedient than, e.g. implementing a process callback.

What would a test look like for this?
There aren't any tests for the other 'browse' link implementations for me to crib.

That looks quite nice. thanks. The problem with it might be that it won't work so well for a right to left language like russian. But probably not a huge deal if the link is before the text.

We have \Drupal\token\Tests\TokenBlockTest already. So basically, what we need to do is on the page where we edit the block, that we add an assertLink() that makes sure the link is displayed there. So it should be like a single additional line.

Yes, I suspected this would happen.

We could try something like t('This field supports tokens. @browse_tokens_link') and then pass in the render array like that, but we probably need to render it ourself then with \Drupal::service('render')->render()

1. +++ b/src/Tests/TokenBlockTest.php
   @@ -48,6 +48,9 @@ class TokenBlockTest extends TokenTestBase {
        $this->drupalGet($block->urlInfo());
   +    // Ensure that the link to available tokens is present and correctly positioned.
   +    $this->assertLink('Browse available tokens.'); //@todo
   

   Comment is too long.

   Remove @todo left-over.

2. +++ b/token.module
   @@ -86,7 +86,15 @@ function token_block_view_alter(&$build, BlockPluginInterface $block) {
   -  $form['settings']['label']['#description'] = t('This field supports tokens.');
   +//  $form['settings']['label']['#description'] = t('This field supports tokens.');
   

   remove the old commented out line.

3. +++ b/token.module
   @@ -86,7 +86,15 @@ function token_block_view_alter(&$build, BlockPluginInterface $block) {
   +  $token_tree = array(
   

   use short array syntax

4. +++ b/token.module
   @@ -86,7 +86,15 @@ function token_block_view_alter(&$build, BlockPluginInterface $block) {
   +  $form['settings']['label']['#description'] = array(
   +    '#prefix' => t('This field supports tokens. @browse_tokens_link', array('@browse_tokens_link' => $rendered_token_tree))
   

   #prefix stuff isn't needed, just = t(...);

Nice, looks good to me.

Agreed, committed.