Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
#2559825: Preprocess functions from base hooks not triggered for theme hooks not using the __ pattern is a bug that forces the use of double underscores in theme hooks in order for base hooks to work as expected.
#2296423: Implement layout plugin type in core works around this by forcibly prepending layout__ to each auto-generated theme hook.
This does not affect the template naming, but does affect the preprocess. This can lead to confusing effects, see #2296423-184: Implement layout plugin type in core for details.
Proposed resolution
Remove workaround from LayoutPluginManager
Remaining tasks
User interface changes
API changes
The naming of preprocess functions will change. Template names will not.
Comments
Comment #2
tim.plunkettComment #3
effulgentsia CreditAttribution: effulgentsia at Acquia commentedFor me, this should be a blocker for
layout_discoveryreaching beta stability level, so raising priority to Major. Because per #2296423-184: Implement layout plugin type in core, I don't think non-experimental core modules should contain occurrences of a mismatch between theme hook name and template name, and per the issue summary, this is an API change in the sense of affecting preprocess function names, so best to do it before beta.Comment #4
effulgentsia CreditAttribution: effulgentsia at Acquia commentedTagging as well, for easier finding later when the module gets close to beta.
Comment #6
tim.plunkettResolved by #2559825: Preprocess functions from base hooks not triggered for theme hooks not using the __ pattern