Problem/Motivation

I was unable to get the pdf_export.js javascript file to be loaded by default which caused the views print PDF javascript link to fail

Proposed resolution

Replace the $page payload set with a simple drupal_add_js call for the same file in the same scope

Original report by generalconsensus

CommentFileSizeAuthor
#5 browser.png38.56 KBcoreteamvn
#3 2833489-js-not-appearing.patch689 bytesgeneralconsensus
#2 2833489-js-not-appearing.patch837 bytesgeneralconsensus

Comments

generalconsensus created an issue. See original summary.

generalconsensus’s picture

generalconsensus commented
StatusFileSize
new 2833489-js-not-appearing.patch837 bytes
generalconsensus’s picture

generalconsensus commented
StatusFileSize
new 2833489-js-not-appearing.patch689 bytes

Fix to file locations

generalconsensus’s picture

generalconsensus commented
Status: Active » Needs review
coreteamvn’s picture

coreteamvn commented
StatusFileSize
new browser.png38.56 KB

Thanks for the patch. It helps in those cases where nothing seems to happen. In Firefox when one opens (as opposed to save the view/pdf) the pdf in the browser it works.

But when I try to save the pdf or save the pdf with Chrome, it saves a text file. In Safari in my case the result is a corrupted file. See screenshot.

  • nbouhid committed bfb6548 on 7.x-1.x 
    Issue #2833489 by generalconsensus, coreteamvn: pdf_export.js not being...
nbouhid’s picture

nbouhid commented
Status: Needs review » Fixed

Thanks for the fix. I updated the patch so it passes the phpcs validation and it's included on the footer so it does not block page rendering.

nbouhid’s picture

nbouhid commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.