Needs review
Project:
Tarpit
Version:
8.x-1.1
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Dec 2016 at 15:46 UTC
Updated:
17 Sep 2025 at 21:32 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
cebasqueira commentedHi @Pol, more improvements!
Thanks my friend!
Comment #3
polAre you sure about this ?
Comment #4
cebasqueira commentedYes, because I changed the variable name on Ban Class of $request_stack to $requestStack, right?
Comment #5
polNo it has nothing to do with variables.
@request_stack is a service !
Comment #6
cebasqueira commentedYou is right, sorry, I will update the patch
Comment #7
cebasqueira commentedComment #8
hgunicamp commentedI applied the 'coding_standards_for_d8-2833166-7.patch' and it was removing a function commentary.
I generated a new patch file ('coding_standards_for_d8-2833166-8.patch ') to fix this problem.
Then rechecked the code standard using the following command without further complains:
find . -type f \( -name '*.php' -or -name '*.yml' -or -name '*.module' \) -exec phpcs --standard=Drupal {} \+
Then I load the patched module in my environment without mistakes using drupal console as shown in the picture 'loading_tarpit.png'.
Comment #9
hgunicamp commentedComment #10
faline commentedSome dependency injection and standards fixes
Comment #11
rodrigoac commentedHello People !
I apply the patch and check the standards.
All looks fine by me !
Thanks @faline !
Comment #12
ressaUpdating the version to the latest release.
Comment #14
ressaThanks everyone for working on this, now more than eight years ago :)
The Tarpit module has become potentially very useful, since it can help block bot attacks for web sites using Facets 2, by offering them Honeypot links, and a ban if they follow them:
- https://www.drupal.org/docs/administering-a-drupal-site/security-in-drup...
- https://www.drupal.org/forum/support/post-installation/2025-02-20/drupal...
I created a GitLab Merge Request based on the last patch from comment #10. There were a few additional deprecations since then, which are also fixed in the MR, and the module works well in Drupal 10.