Problem/Motivation

Recently, tests were rearranged in media_entity for #2796901: Convert all web tests to BTB where possible, increase test coverage and split existing tests into more granular classes.. This breaks this module's TweetEmbedFormatterTest.

Proposed resolution

Convert this test case to BTB as well.

Remaining tasks

  • Further fix test
  • Review

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 media_entity_twitter-convert-btb-2832409-2-d8.patch1.31 KBeelkeblok

Comments

eelkeblok created an issue. See original summary.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
StatusFileSize
new media_entity_twitter-convert-btb-2832409-2-d8.patch1.31 KB

Found this while working on #2625854: Provide default source_field when creating new media entity bundles. This moves the test case below tests and extends the MediaEntityFunctionalTestBase instead of WebTestBase. It still throws a notice, though, but wanted to get this out, since others might run into this and #2625854: Provide default source_field when creating new media entity bundles might take some more time to land completely.

slashrsm’s picture

slashrsm commented
Status: Active » Needs review
Issue tags: +D8Media

Status: Needs review » Needs work

The last submitted patch, 2: media_entity_twitter-convert-btb-2832409-2-d8.patch, failed testing.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented

OK, testbot seems to use an older version of media_entity that does not contain the change yet.

slashrsm’s picture

slashrsm commented

Yes. Drupal CI is using tagged releases. It would make sense to prepare similar patches in other ME module otherwise we'll break tests in them when we tag new release of main module.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Closed (duplicate)
Related issues: +#2869157: Twitter Port to the proposed Media core module API

This has already been done in #2869157: Twitter Port to the proposed Media core module API ; commit cbabe5f.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.