Update to Symfony ~3.2 [#2831757]

Problem/Motivation

Follow-up to #2712647: Update Symfony components to ~3.2 since 3.2.0 is already out. Symfony 3.2.0 was released on November 30, 2016. See #2712647: Update Symfony components to ~3.2 for the current status of the issue.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#37	interdiff.txt	3.02 KB	slasher13
#37	2831757-37.patch	91.38 KB	slasher13
#37	8.4.x: PHP 5.6 & MySQL 5.5 21,455 pass PHP 7.1 & MySQL 5.5 19,688 pass PHP 7 & MySQL 5.5 19,688 pass PHP 5.5 & MySQL 5.5 21,455 pass
#34	interdiff.txt	1.91 KB	slasher13
#34	2831757-34.patch	95.63 KB	slasher13
#34	8.4.x: PHP 5.6 & MySQL 5.5 21,446 pass, 2 fail PHP 7.1 & MySQL 5.5 19,679 pass, 2 fail PHP 7 & MySQL 5.5 19,678 pass, 3 fail
#33	2831757-33.patch	93.93 KB	slasher13
#33	8.4.x: PHP 5.6 & MySQL 5.5 21,062 pass, 1,222 fail PHP 7.1 & MySQL 5.5 19,295 pass, 1,222 fail PHP 7 & MySQL 5.5 19,295 pass, 1,222 fail
#26	2831757-26.patch	94.18 KB	slasher13
#26	8.3.x: PHP 5.6 & MySQL 5.5 21,402 pass PHP 7.1 & MySQL 5.5 19,648 pass PHP 7 & MySQL 5.5 19,648 pass
#21	2831757-21.patch	92.7 KB	slasher13
#21	8.3.x: PHP 5.6 & MySQL 5.5 21,408 pass, 1 fail PHP 7.1 & MySQL 5.5 19,659 pass, 1 fail PHP 7 & MySQL 5.5 19,659 pass, 1 fail
#21	interdiff.txt	1.78 KB	slasher13
#19	interdiff.txt	41.97 KB	slasher13
#19	2831757-19.patch	91.14 KB	slasher13
#19	8.3.x: PHP 5.6 & MySQL 5.5 21,013 pass, 1,207 fail PHP 7.1 & MySQL 5.5 19,266 pass, 1,207 fail PHP 7 & MySQL 5.5 19,266 pass, 1,207 fail
#18	interdiff-2712647-301.txt	26.02 KB	slasher13
#18	interdiff.txt	12.51 KB	slasher13
#18	2831757-18.patch	96.27 KB	slasher13
#18	8.3.x: PHP 5.5 & MySQL 5.5 21,405 pass, 1 fail
#13	interdiff.txt	1.4 KB	slasher13
#13	2831757-13.patch	97.07 KB	slasher13
#13	8.3.x: PHP 5.5 & MySQL 5.5 21,282 pass PHP 7 & MySQL 5.5 19,538 pass PHP 5.5 & PostgreSQL 9.1 21,399 pass, 2 fail PHP 5.5 & SQLite 3.8 21,400 pass, 1 fail PHP 5.6 & MySQL 5.5 21,282 pass PHP 7 & PostgreSQL 9.1 19,652 pass, 2 fail PHP 7 & SQLite 3.14 19,618 pass, 1 fail
#11	interdiff.txt	1.22 KB	slasher13
#11	2831757-11.patch	95.67 KB	slasher13
#11	8.3.x: PHP 5.5 & MySQL 5.5 21,278 pass, 4 fail PHP 7 & MySQL 5.5 19,534 pass, 4 fail
#7	interdiff.txt	694 bytes	Wim Leers
#7	2831757-7.patch	27.21 KB	Wim Leers
#7	8.3.x: PHP 5.5 & MySQL 5.5 21,286 pass, 72 fail PHP 7 & MySQL 5.5 19,541 pass, 91 fail
#4	2831757-4.patch	27.22 KB	Wim Leers
#4	8.3.x: PHP 5.5 & MySQL 5.5 21,286 pass, 72 fail PHP 7 & MySQL 5.5 19,542 pass, 89 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

30 November 2016 at 13:26

catch created an issue. See original summary.

Comment #2

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 1 December 2016 at 12:15

Status:

Postponed

» Active

#2712647: Update Symfony components to ~3.2 is in.

Comment #3

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 1 December 2016 at 12:16

Issue summary:	View changes
Related issues:		+#2712647: Update Symfony components to ~3.2

Comment #4

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 1 December 2016 at 12:23

Status:

Active

» Needs review

File	Size
2831757-4.patch	27.22 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,286 pass, 72 fail PHP 7 & MySQL 5.5 19,542 pass, 89 fail

composer update symfony/*

Comment #5

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 1 December 2016 at 12:32

Issue tags:

+Needs change record

CR will need to point to https://github.com/symfony/symfony/blob/master/UPGRADE-3.2.md. Or perhaps we just want to update https://www.drupal.org/node/2743809 ?

Comment #6

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi at jobiqo - job board technology commented 1 December 2016 at 12:50

Status:

Needs review

» Needs work

+++ b/core/composer.json
@@ -5,20 +5,20 @@
+        "symfony/dependency-injection": "~3.2",
+        "symfony/dom-crawler": ">=3.2 <4.0",
+        "symfony/event-dispatcher": "~3.2",
+        "symfony/http-foundation": ">=3.2 <4.0",
+        "symfony/http-kernel": "~3.2",

3.2 already contains the dom-crawler and http-foundation fixes, so we can use ~3.2. I hate the "~" operator because nobody can read it, but I hate inconsistency even more :-D

File	Size
2831757-7.patch	27.21 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,286 pass, 72 fail PHP 7 & MySQL 5.5 19,541 pass, 91 fail
interdiff.txt	694 bytes

Comment #8

1 December 2016 at 13:14

The last submitted patch, 4: 2831757-4.patch, failed testing.

Comment #9

1 December 2016 at 13:52

Status:

Needs review

» Needs work

The last submitted patch, 7: 2831757-7.patch, failed testing.

Comment #10

jibran

he/him

Urdu

Sydney, Australia

CreditAttribution: jibran as a volunteer commented 1 December 2016 at 13:58

The patch is missing symfony/css-selector.

Comment #11

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 5 December 2016 at 13:13

Status:	Needs work	» Needs review
Related issues:		+#2573807: Fatal error: Call to a member function getTimestamp()

File	Size
2831757-11.patch	95.67 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,278 pass, 4 fail PHP 7 & MySQL 5.5 19,534 pass, 4 fail
interdiff.txt	1.22 KB

patch on top of https://www.drupal.org/node/2712647#comment-11808905
and https://www.drupal.org/node/2573807#comment-11810963, but why isn't the expires header set?

Comment #12

5 December 2016 at 13:56

Status:

Needs review

» Needs work

The last submitted patch, 11: 2831757-11.patch, failed testing.

Comment #13

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 5 December 2016 at 20:41

Status:

Needs work

» Needs review

File	Size
2831757-13.patch	97.07 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,282 pass PHP 7 & MySQL 5.5 19,538 pass PHP 5.5 & PostgreSQL 9.1 21,399 pass, 2 fail PHP 5.5 & SQLite 3.8 21,400 pass, 1 fail PHP 5.6 & MySQL 5.5 21,282 pass PHP 7 & PostgreSQL 9.1 19,652 pass, 2 fail PHP 7 & SQLite 3.14 19,618 pass, 1 fail
interdiff.txt	1.4 KB

changes from https://github.com/symfony/http-foundation/commit/295423690c79e35a59d2ae...

Comment #14

jibran

he/him

Urdu

Sydney, Australia

CreditAttribution: jibran as a volunteer commented 6 December 2016 at 12:52

Do we have to update these files?

core/lib/Drupal/Core/DependencyInjection/ContainerBuilder.php
core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php

Comment #15

jibran

he/him

Urdu

Sydney, Australia

CreditAttribution: jibran as a volunteer commented 6 December 2016 at 12:52

Do we have to update these files?

core/lib/Drupal/Core/DependencyInjection/ContainerBuilder.php
core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php

Comment #16

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 9 December 2016 at 09:14

core/lib/Drupal/Core/DependencyInjection/ContainerBuilder.php
core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php

we have only the changes from https://www.drupal.org/node/2712647.

Should I merge this into https://www.drupal.org/node/2712647 without https://www.drupal.org/node/2573807?

Comment #17

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 12 December 2016 at 22:08

Looking at it, it doesn't seem like #2573807 has any connection to this? I'd vote to merge this back into #2712647.

Comment #18

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 13 December 2016 at 14:40

File	Size
2831757-18.patch	96.27 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,405 pass, 1 fail
interdiff.txt	12.51 KB
interdiff-2712647-301.txt	26.02 KB

update to symfony 3.2.1 and remove #2573807 from patch
add interdiff to #2712647 https://www.drupal.org/node/2712647?page=1#comment-11824003

File	Size
2831757-19.patch	91.14 KB
8.3.x: PHP 5.6 & MySQL 5.5 21,013 pass, 1,207 fail PHP 7.1 & MySQL 5.5 19,266 pass, 1,207 fail PHP 7 & MySQL 5.5 19,266 pass, 1,207 fail
interdiff.txt	41.97 KB

Comment #20

13 January 2017 at 00:16

Status:

Needs review

» Needs work

The last submitted patch, 19: 2831757-19.patch, failed testing.

File	Size
interdiff.txt	1.78 KB
2831757-21.patch	92.7 KB
8.3.x: PHP 5.6 & MySQL 5.5 21,408 pass, 1 fail PHP 7.1 & MySQL 5.5 19,659 pass, 1 fail PHP 7 & MySQL 5.5 19,659 pass, 1 fail

Comment #22

jibran

he/him

Urdu

Sydney, Australia

CreditAttribution: jibran as a volunteer commented 13 January 2017 at 11:19

Status:

Needs review

» Reviewed & tested by the community

I think we can use https://www.drupal.org/node/2743809 as a change record for this issue and 3.1 issue has no momentum so I'm going to be bold and set it to RTBC. We can close 3.1 one as a duplicate.

Comment #23

naveenvalecha

He/Him

Hindi

CreditAttribution: naveenvalecha as a volunteer commented 13 January 2017 at 11:33

would you update the CR including the changes in 3.2 accordingly
//Naveen

Comment #24

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 13 January 2017 at 12:23

@jibran the 3.1 issue has no momentum because it makes Drupal incompatible with drush, see https://github.com/drush-ops/drush/pull/2477

Comment #25

14 January 2017 at 12:10

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 21: 2831757-21.patch, failed testing.

File	Size
2831757-26.patch	94.18 KB
8.3.x: PHP 5.6 & MySQL 5.5 21,402 pass PHP 7.1 & MySQL 5.5 19,648 pass PHP 7 & MySQL 5.5 19,648 pass

Comment #27

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 16 January 2017 at 13:44

Status:

Needs review

» Reviewed & tested by the community

Back to RTBC as #22

Comment #28

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott at Chapter Three commented 16 January 2017 at 13:46

Status:	Reviewed & tested by the community	» Postponed
Related issues:		+#2843828: \Drupal\Core\DrupalKernel::initializeSettings() can result in moving the autoloader position

This is at least postponed on #2843828: \Drupal\Core\DrupalKernel::initializeSettings() can result in moving the autoloader position and it is probably postponed on working out a way forward for https://github.com/drush-ops/drush/pull/2477

Comment #29

catch

he/him

English

CreditAttribution: catch at Third and Grove commented 16 January 2017 at 14:17

Discussed this a bit with @alexpott and @xjm, at the moment we think we should commit this early in 8.4.x - this gives additional time to keep rolling back and re-committing the update as new things are uncovered, as well as more time to determine if there needs to be a new minor or major drush release.

Comment #30

TJacksonVA CreditAttribution: TJacksonVA commented 19 January 2017 at 19:09

Are there any changes/additions from Symfony 2.8 to Symfony 3.2 or 3.3 that Drupal 8.x module developers would find important or useful? If so, it may be a mistake to wait until Drupal 8.4.x to implement the Symfony upgrade.

Comment #31

pounard

French

CreditAttribution: pounard commented 20 January 2017 at 08:03

Are there any changes/additions from Symfony 2.8 to Symfony 3.2 or 3.3 that Drupal 8.x module developers would find important or useful? If so, it may be a mistake to wait until Drupal 8.4.x to implement the Symfony upgrade.

As soon as you use external components, it's safe to say upgrading to 3.2 is a plus. I personally work with many libraries where I do need 3.2 - for a site to come in a few months, I was awaiting for Drupal 8.3 to bring Symfony 3.2 and some other fixes along to play well with it.

Comment #32

20 January 2017 at 08:03

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #33

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 28 January 2017 at 13:40

Status:

Postponed

» Needs review

File	Size
2831757-33.patch	93.93 KB
8.4.x: PHP 5.6 & MySQL 5.5 21,062 pass, 1,222 fail PHP 7.1 & MySQL 5.5 19,295 pass, 1,222 fail PHP 7 & MySQL 5.5 19,295 pass, 1,222 fail

re-roll

Comment #34

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 28 January 2017 at 14:05

File	Size
2831757-34.patch	95.63 KB
8.4.x: PHP 5.6 & MySQL 5.5 21,446 pass, 2 fail PHP 7.1 & MySQL 5.5 19,679 pass, 2 fail PHP 7 & MySQL 5.5 19,678 pass, 3 fail
interdiff.txt	1.91 KB

Comment #35

28 January 2017 at 14:22

The last submitted patch, 33: 2831757-33.patch, failed testing.

Comment #36

28 January 2017 at 15:08

Status:

Needs review

» Needs work

The last submitted patch, 34: 2831757-34.patch, failed testing.

Comment #37

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 28 January 2017 at 15:31

Status:

Needs work

» Needs review

File	Size
2831757-37.patch	91.38 KB
8.4.x: PHP 5.6 & MySQL 5.5 21,455 pass PHP 7.1 & MySQL 5.5 19,688 pass PHP 7 & MySQL 5.5 19,688 pass PHP 5.5 & MySQL 5.5 21,455 pass
interdiff.txt	3.02 KB

Comment #38

28 January 2017 at 19:26

Status:

Needs review

» Needs work

The last submitted patch, 37: 2831757-37.patch, failed testing.

Comment #39

slasher13

German

CreditAttribution: slasher13 as a volunteer and at Wolters Kluwer commented 29 January 2017 at 15:58

Status:

Needs work

» Needs review

Comment #40

xjm

she/her

English

CreditAttribution: xjm at Acquia commented 30 January 2017 at 15:11

Issue summary:

View changes

This should either be postponed on the 3.1 update, or merged into it. See the summary of #2712647: Update Symfony components to ~3.2. We need to allow time for contrib and drush to fully support Symfony 3.