Update to Symfony ~3.2

#2712647: Update Symfony components to ~3.2 is in.

composer update symfony/*

CR will need to point to https://github.com/symfony/symfony/blob/master/UPGRADE-3.2.md. Or perhaps we just want to update https://www.drupal.org/node/2743809 ?

+++ b/core/composer.json
@@ -5,20 +5,20 @@
+        "symfony/dependency-injection": "~3.2",
+        "symfony/dom-crawler": ">=3.2 <4.0",
+        "symfony/event-dispatcher": "~3.2",
+        "symfony/http-foundation": ">=3.2 <4.0",
+        "symfony/http-kernel": "~3.2",

3.2 already contains the dom-crawler and http-foundation fixes, so we can use ~3.2. I hate the "~" operator because nobody can read it, but I hate inconsistency even more :-D

hehe :)

The patch is missing symfony/css-selector.

patch on top of https://www.drupal.org/node/2712647#comment-11808905
and https://www.drupal.org/node/2573807#comment-11810963, but why isn't the expires header set?

changes from https://github.com/symfony/http-foundation/commit/295423690c79e35a59d2ae...

Do we have to update these files?

core/lib/Drupal/Core/DependencyInjection/ContainerBuilder.php
core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php

Do we have to update these files?

core/lib/Drupal/Core/DependencyInjection/ContainerBuilder.php
core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php

In

core/lib/Drupal/Core/DependencyInjection/ContainerBuilder.php
core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php

we have only the changes from https://www.drupal.org/node/2712647.

Should I merge this into https://www.drupal.org/node/2712647 without https://www.drupal.org/node/2573807?

Looking at it, it doesn't seem like #2573807 has any connection to this? I'd vote to merge this back into #2712647.

• update to symfony 3.2.1 and remove #2573807 from patch
• add interdiff to #2712647 https://www.drupal.org/node/2712647?page=1#comment-11824003

update to symfony 3.2.2

fix wrong merge from #19

I think we can use https://www.drupal.org/node/2743809 as a change record for this issue and 3.1 issue has no momentum so I'm going to be bold and set it to RTBC. We can close 3.1 one as a duplicate.

would you update the CR including the changes in 3.2 accordingly
//Naveen

re-roll

Back to RTBC as #22

This is at least postponed on #2843828: \Drupal\Core\DrupalKernel::initializeSettings() can result in moving the autoloader position and it is probably postponed on working out a way forward for https://github.com/drush-ops/drush/pull/2477

Are there any changes/additions from Symfony 2.8 to Symfony 3.2 or 3.3 that Drupal 8.x module developers would find important or useful? If so, it may be a mistake to wait until Drupal 8.4.x to implement the Symfony upgrade.

Are there any changes/additions from Symfony 2.8 to Symfony 3.2 or 3.3 that Drupal 8.x module developers would find important or useful? If so, it may be a mistake to wait until Drupal 8.4.x to implement the Symfony upgrade.

As soon as you use external components, it's safe to say upgrading to 3.2 is a plus. I personally work with many libraries where I do need 3.2 - for a site to come in a few months, I was awaiting for Drupal 8.3 to bring Symfony 3.2 and some other fixes along to play well with it.

re-roll

This should either be postponed on the 3.1 update, or merged into it. See the summary of #2712647: Update Symfony components to ~3.2. We need to allow time for contrib and drush to fully support Symfony 3.

see https://www.drupal.org/node/2712647#comment-11901458