No validation found while adding selectors in the settings form. Duplicate selectors, special characters can be added in the form.

CommentFileSizeAuthor
#6 no_duplicate_selectors.png44.13 KBdeepa_lissa
#6 no_space_before and_after_selector.png42.93 KBdeepa_lissa
#6 no_special_characters.png40.49 KBdeepa_lissa
#5 validation_for_adding_selectors-2831670-5.patch2.69 KBakhilavnair
#2 validation_for_adding_selectors-2831670-2.patch2.69 KBakhilavnair

Comments

akhilavnair_zyxware created an issue. See original summary.

akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
commented
StatusFileSize
new validation_for_adding_selectors-2831670-2.patch2.69 KB

Created a patch to fix the validation issues in the settings form. Please use this patch after applying the patch from https://www.drupal.org/node/2831420

akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
commented
Status: Active » Needs review
akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
commented
Assigned: akhilavnair » Unassigned
akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
commented
StatusFileSize
new validation_for_adding_selectors-2831670-5.patch2.69 KB

Updated the patch with slight changes, please review the same.

deepa_lissa’s picture

deepa_lissa commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new no_special_characters.png40.49 KB
new no_space_before and_after_selector.png42.93 KB
new no_duplicate_selectors.png44.13 KB

Patch works fine, got errors for invalid selectors. Screenshots for error messages are attached here.

zyxware’s picture

zyxware commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.