Hi Adam,

Great job with E-Sign. It works seamlessly and pairs really well with Webform 2 PDF for producing signed contracts.

I did a little testing and thought the following couple of suggestions would be of interest. They seem pretty easy to implement.

1. Present a choice to enable/disable "Signer name" and "Signer title." The reason would be that these may be collected elsewhere in the form.

2. Allow Webform tokens to be used for "Signer name" and "Signer title" (e.g. "Signer name" = [submission:values:client_first_name:nolabel] [submission:values:client_last_name:nolabel]). The reason would be to avoid redundancy where these are collected elsewhere in the form, and it #1 is not possible.

3. Save "Signer name" and "Signer title" in separately in other text fields. The reason for this would be if options #1 and #2 are not possible, redundant entry is not desirable, and the name data needs to be imported elsewhere.

Cheers

CommentFileSizeAuthor
#9 esign-field-options-2831188-9.patch10.23 KBjeffm2001

Comments

gnurob created an issue. See original summary.

greatmatter’s picture

greatmatter commented

Thank you!

I'll add these to my to-do list--no promises on when I might finish them.

I can tell you that #1 enabling/disabling of "Signer Name" and "Signer Title" are already on the list.

I want to get a little more info from you on #2, though: while it could work well to have tokens *after* a form is submitted, it won't do much good to have them beforehand, as the tokenized values wouldn't be initialized yet. Is that what you had in mind?

For #3: Great idea: I'll have to figure out how I'll do it + an upgrade path.

greatmatter’s picture

greatmatter commented
Assigned: Unassigned » greatmatter
gnurob’s picture

gnurob commented

Hi, glad to hear your so active with this!

Based on your explanation, #2 may not work. The concept would be relevant to a multi-page form where a submitter may add their name to page one, and several pages later, sign the document and the Signer Name would have their name pre-filled. My thoughts were that if #1 would not be possible, #2 would be a compromise. There is a remote scenario where a form could be submitted on behalf of someone else, for example a parent entering into a contract on behalf of a minor, but it wasn't on my list of concerns for suggesting #2. If #1 is on your to-do list, that's probably good enough.

Maybe #3 could be solved with using those tokens on hidden fields? I'm no expert on this...

On the other hand, if #1 were solved, a form creator could just slide in their own name input fields to the same location, so #3 would be nice to have, but not urgent.

greatmatter’s picture

greatmatter commented

Thanks for the clarification.

I think we'll end up going with #1 for now.

I don't have a firm timeline on the mods, though. I'll keep you posted.

sohal khatwani’s picture

sohal khatwani commented

Any update on these requests? Thanks.

royash’s picture

royash commented
Version: 7.x-1.6 » 7.x-1.9

Hi Adam

Any news on amending issue #1?

Regards

Roy

greatmatter’s picture

greatmatter commented

Unfortunately not. I've been slammed; this has taken a backseat. A co-maintainer would probably be great to handle these feature requests.

jeffm2001’s picture

jeffm2001 commented
Version: 7.x-1.9 » 7.x-1.x-dev
Assigned: greatmatter » Unassigned
Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new esign-field-options-2831188-9.patch10.23 KB

The attached patch allows the Signer Name/Title inputs to be disabled. It adds "Collect Name" and "Collect Title" checkboxes (default checked) to the field widget and webform component settings forms, as well as corresponding properties for the FAPI element array.

It also cleans up a couple of PHP notices when you first add a e-signature field to a node and when you add it through the Form API without '#field_name' or '#description' set. Also a spelling error in the webform component settings.

delacosta456’s picture

delacosta456 commented

hi @JeffM2001
Very nice work and many thanks for that .. i will apply the patch and let you know if any issue

delacosta456’s picture

delacosta456 commented

hi
i applied the patch and everything is ok for me

matt b’s picture

matt b
Primary language English
commented

Good work @JeffM2001 - just what I needed. I've applied the patch and can confirm it works for webform components.

tonovcp’s picture

tonovcp commented

Hi,
I cannot make it work with webform2pdf, always get TCPDF ERROR: [Image] Unable to get the size of the image:data:image/png;base64,.... But I am no coder and don't know how to solve it. Any idea?
Thank you

dankh’s picture

dankh commented
Status: Needs review » Reviewed & tested by the community

I have re-tested the patch against the latest release 7.x-1.10 and latest dev, I can confirm it works as expected. Do we have any blockers to get this in the module ?

matt b’s picture

matt b
Primary language English
commented

Also re-tested the patch against 7.x-1.10. Please commit this patch.

greatmatter’s picture

greatmatter commented

Hey, everyone--we've tweaked this considerably to avoid issues with backwards compatibility. Instead of "collect_" it's "hide_" so that anything that doesn't have something checked already will still behave normally.

Regarding tokens: we'll figure that into a future release, if it's still pertinent.

Please see version 1.12, just released.

greatmatter’s picture

greatmatter commented
Status: Reviewed & tested by the community » Fixed
greatmatter’s picture

greatmatter commented
Status: Fixed » Closed (fixed)
cocco.christian’s picture

cocco.christian commented

Dear all
how can I take the token of signature, the signer name, title and date separately?

For example...is possibile somethink like this?
[submission:values:field_name:signer_title]

Cheers