There is an error after installation in module Tribune local.

Notice: Undefined property: stdClass::$tribune_type in function tribune_local_block_info() (line 1032 in file ***/public_html/sites/all/modules/tribune/backends/tribune_local/tribune_local.module).

I simply solved it by replacing line 1032 by:

if (!empty($tribune->tribune_type) == 'local') {

CommentFileSizeAuthor
#3 if_condition_check-2830628-3.patch715 bytesUjwala_D

Comments

prostowebsite created an issue. See original summary.

prostowebsite’s picture

prostowebsite commented
Assigned: prostowebsite » Unassigned
Ujwala_D’s picture

Ujwala_D commented
Status: Active » Needs review
StatusFileSize
new if_condition_check-2830628-3.patch715 bytes

Hi,

As mentioned above if (!empty($tribune->tribune_type) == 'local') {

The 'empty' function return TRUE or FALSE. so it will check either (1 == 'local') or (0 == 'local') which is totally wrong and bad coding practises.

Please check the patch for correct if condition.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs review » Fixed

Thanks for the report.
Thanks for the patch, that looks like a perfect pix :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.