Any chances this will be ported to drupal 8? Looking to use this on a new site but it has to be drupal 8 for various reasons! Might give it a go myself as I have written drupal modules myself in the past just not for 8!

Comments

cjsmith87 created an issue. See original summary.

tanzeel’s picture

Ported to Drupal 8, it is development release but working fine. I will upload recommended release after testing different scenarios.

Cheers,

tanzeel’s picture

Status: Active » Needs review
fernly’s picture

Version: 7.x-1.3 » 8.x-1.x-dev
StatusFileSize
new28.29 KB

I did a near-full refactor of the D8 version.

Some (bigger) changes:

  • Using config entity for configuration instead of wrongly using Drupal state
  • Renamed configuration variables
  • Refactored query
  • Using dependency injection where possible
  • The twig template changed slightly in variables
  • Possibility to get suggestions over all content types or only the one that is being used
  • Optionally display the content type in the suggestions

The logic and module behaviour stay the same.

mpp’s picture

+++ b/config/schema/suggest_similar_titles.schema.yml
@@ -0,0 +1,25 @@
+      label: 'Number of nodes'

This should be "Check node access"

bobbygryzynger’s picture

Updated the patch to prevent an empty processed title array from being passed to the query-generating function. An empty title array will cause the OR group in getMatchingTitles() to be empty which will cause the errors documented in #2923690: Empty conditions groups might break the query due to empty where generated.

bobbygryzynger’s picture

StatusFileSize
new850 bytes

Attaching interdiff here.

cruno’s picture

Adding a patch that also includes support for inline entity forms. This is needed when using node creation within entity browsers.

It may make more sense to upload this as its own separate issue, but it relies on the patch in #6 to work, so I just re-rolled that patch with this work. I could re-roll the patch for a separate issue if needed.

  • adriancid committed f1f76c7 on 8.x-1.x authored by lennartvv
    Issue #2829320 by bobbygryzynger, lennartvv, cruno, cjsmith87, mpp,...
adriancid’s picture

Status: Needs review » Fixed

I pushed the patch and now is better if we create new issues for the new features/bugs/tasks.

I will check this project in the next days to see if we can release the first D8 version.

mpp’s picture

Great work, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.