Offcanvas width is not reset if tray is open with different width and not closed

1. +++ b/core/modules/outside_in/src/Ajax/OpenOffCanvasDialogCommand.php
   @@ -11,6 +11,8 @@
   +  const DIALOG_WIDTH = 300;
   

   Needs a comment

2. +++ b/core/modules/outside_in/src/Ajax/OpenOffCanvasDialogCommand.php
   @@ -42,6 +44,9 @@ public function __construct($title, $content, array $dialog_options = [], $setti
   +    if (empty($this->dialogOptions['width'])) {
   

   Is it ever reasonable to set this to 0? If so, switch to !isset. And either way, probably worth a comment here.

3. +++ b/core/modules/outside_in/src/Ajax/OpenOffCanvasDialogCommand.php
   @@ -42,6 +44,9 @@ public function __construct($title, $content, array $dialog_options = [], $setti
   +      $this->dialogOptions['width'] = self::DIALOG_WIDTH;
   

   static::

4. +++ b/core/modules/outside_in/tests/src/FunctionalJavascript/OffCanvasTest.php
   @@ -59,6 +59,10 @@ public function testOffCanvasLinks() {
              self::assertTrue(strstr($style, 'width: 555px;') !== FALSE, 'Dialog width respected.');
   ...
   +          self::assertTrue(strstr($style, 'width: 555px;') === FALSE, 'Dialog width reset to default.');
   

   Idk who used self::assertTrue but that should have been $this->assertTrue() to be the same as core, or at the least static::assertTrue()...

Er, I meant !isset. Hopefully that patch fails, or we need more coverage.

Re-rolling patch.

Followed reroll documentation & resolved conflict in file core/module/outside_in/test/src/FunctionalJavascript/OffCanvasTest.php at Step 9.

Wrong patch...sorry. Missed something in previous one.

Attaching correct one & queuing for test.

@tedbow - Changes done as per your comment. Attaching patch for review & queuing it for test..

@tedbow I confirmed that the patch applies and works as expected. However, I'd recommend changing the constant name from DIALOG_WIDTH to DEFAULT_DIALOG_WIDTH to make the intention clearer.

@tedbow - Let me know if another patch is needed here as per suggestion in #26.

Attaching another patch with changed constant name to DEFAULT_DIALOG_WIDTH from DIALOG_WIDTH after confirmation from @tedbow.

Forgot to mention in #26 that I also confirmed that all of the issues from the code review in #13 have been addressed.

The bug fix looks goods. Committed 359663b and pushed to 8.4.x. Thanks!

Since this only affects an experimental module, I think this could be backported to 8.3.x.

Yep, as an experimental module change, this is backportable to 8.3.x. It changes only code within the module.

Cherry picked 3cd15f0 and pushed to 8.3.x. Thanks!