The hoverIntent library is not being called correctly.

/src/Plugin/Block/SuperfishBlock.php

line 674 needs to be:

$build['#attached']['library'][] = 'superfish/superfish_hoverintent';

The original was calling:

$build['#attached']['library'][] = 'superfish/hoverintent';

Comments

trickyricky26 created an issue. See original summary.

cebasqueira’s picture

Assigned: Unassigned » cebasqueira
cebasqueira’s picture

Assigned: cebasqueira » Unassigned
Status: Active » Needs review
StatusFileSize
new605 bytes

  • mehrpadin committed f972f83 on 8.x-1.x
    issue #2828697 by cebasqueira: Fixed the hoverintent library label.
    
larruda’s picture

Hi @mehrpadin, would you please close this issue and give the credit to @cebasqueira accordingly? Thanks a lot!

duaelfr’s picture

Status: Needs review » Fixed

Cleaning the issue queue. I don't think that this commit is going to be rewritten to give authorship. The issue attribution has already been given to @mehrpadin.

larruda’s picture

The issue credit has been attributed to @mehrpadin but who actually have written the patch was @cebasqueira. The later should have gained credit for such work, as well as the proper commit on behalf oh him. This is a matter of courtesy, specially when people are coming here to help your project voluntarily.

duaelfr’s picture

You are totally right. I'm just cleaning the issue queue because the maintainer doesn't. Now the commit has been made, pushed and tagged for a release, it's certainly not going to be rewritten. The only thing the maintainer could do is to change the attribution of this issue but I'm quite sure it won't happen.

geek.geek’s picture

Hi,

All the credit goes to cebasqueira indeed as you can see in the commit message:
issue #2828697 by cebasqueira: Fixed the hoverintent library label.

Am I missing something here?

Also https://www.drupal.org/node/52287#credit

larruda’s picture

Hi @geek.geek, yes you are missing two things here, let me show you:

1) The commit must be done by the module maintainer *on behalf* of who contributed with the patch. This means that when issuing "git commit" command you also need to specify the commit author by using the --author option and passing along a reference to that user. The link you sent references another that explains what I'm talking about, see: https://www.drupal.org/node/1146430. If you scroll down this same page you'll see that Drupal.org help us by generating a full ready-to-use command for this.
See the difference of these commits with and without commit crediting done right:
- https://www.drupal.org/commitlog/commit/52024/f597024a8e53494c6068613f5a...
- https://www.drupal.org/commitlog/commit/13202/f972f83b041cefb7f3100e3ea4...

2) The maintainer must change the issue status to Fixed and before submitting this form with the change he needs to give proper credit to all those who contributed with the issue. This can be done in the "Credit & committing" fieldset right below (the same with the command I just told you about) by checking the users and then saving the form. You can see this worked if you see the related credit in the user's page (e.g.: https://www.drupal.org/u/cebasqueira - Superfish is not listed).

Got it? :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.