Closed (fixed)
Project:
Superfish Dropdown Menu
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Nov 2016 at 05:14 UTC
Updated:
11 Dec 2016 at 22:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
cebasqueira commentedComment #3
cebasqueira commentedComment #5
larruda commentedHi @mehrpadin, would you please close this issue and give the credit to @cebasqueira accordingly? Thanks a lot!
Comment #6
duaelfrCleaning the issue queue. I don't think that this commit is going to be rewritten to give authorship. The issue attribution has already been given to @mehrpadin.
Comment #7
larruda commentedThe issue credit has been attributed to @mehrpadin but who actually have written the patch was @cebasqueira. The later should have gained credit for such work, as well as the proper commit on behalf oh him. This is a matter of courtesy, specially when people are coming here to help your project voluntarily.
Comment #8
duaelfrYou are totally right. I'm just cleaning the issue queue because the maintainer doesn't. Now the commit has been made, pushed and tagged for a release, it's certainly not going to be rewritten. The only thing the maintainer could do is to change the attribution of this issue but I'm quite sure it won't happen.
Comment #9
geek.geek commentedHi,
All the credit goes to cebasqueira indeed as you can see in the commit message:
issue #2828697 by cebasqueira: Fixed the hoverintent library label.Am I missing something here?
Also https://www.drupal.org/node/52287#credit
Comment #10
larruda commentedHi @geek.geek, yes you are missing two things here, let me show you:
1) The commit must be done by the module maintainer *on behalf* of who contributed with the patch. This means that when issuing "git commit" command you also need to specify the commit author by using the --author option and passing along a reference to that user. The link you sent references another that explains what I'm talking about, see: https://www.drupal.org/node/1146430. If you scroll down this same page you'll see that Drupal.org help us by generating a full ready-to-use command for this.
See the difference of these commits with and without commit crediting done right:
- https://www.drupal.org/commitlog/commit/52024/f597024a8e53494c6068613f5a...
- https://www.drupal.org/commitlog/commit/13202/f972f83b041cefb7f3100e3ea4...
2) The maintainer must change the issue status to Fixed and before submitting this form with the change he needs to give proper credit to all those who contributed with the issue. This can be done in the "Credit & committing" fieldset right below (the same with the command I just told you about) by checking the users and then saving the form. You can see this worked if you see the related credit in the user's page (e.g.: https://www.drupal.org/u/cebasqueira - Superfish is not listed).
Got it? :)