At the moment retrieving/saving data with TupasSessionStorage is unnecessary complex.

We could just pass SessionData object to save() and return SessionData when calling get() rather than converting and returning an array and then converting it back to SessionData in TupasSessionManager::getSession().

Current TupasSessionManager::migrate() implementation needs to be refactored too. We're writing a lot duplicate code to migrate sessions after login/register events.

CommentFileSizeAuthor
refactor-session-manager.patch27.08 KBtuutti

Comments

tuutti created an issue. See original summary.

tuutti’s picture

Status: Active » Needs review

  • tuutti committed a6f2659 on 8.x-1.x
    Issue #2828166 by tuutti: Refactor TupasSessionManager and...
tuutti’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.