Problem/Motivation

#2656202: Add Simple English to Drupal core Added Simple English on localize.drupal.org. To make it easy to add to Drupal installs, we should add a more simple key for the Simple English in the core.

Proposed resolution

Update the key for the Simple English from 'en-x-simple' to 'enx'.

Remaining tasks

Do it.

User interface changes

Will be more simple to use in the interface when required to remember the key.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#18 Screenshot 2021-09-27 at 4.48.43 PM.png669.83 KBmadhu_h
#18 Screenshot 2021-09-27 at 4.48.27 PM.png239.73 KBmadhu_h
#10 2824443-10.patch701 byteszahord
#2 2824443.patch739 byteszahord

Comments

zahord created an issue. See original summary.

zahord’s picture

zahord commented
StatusFileSize
new 2824443.patch739 bytes
andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.2.x-dev » 8.3.x-dev

Please elaborate why that makes sense to change

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

There's a patch, let's see what tests will say

Status: Needs review » Needs work

The last submitted patch, 2: 2824443.patch, failed testing.

zahord’s picture

zahord commented

I think that use a single key without dashes ('-'), it may be easier to remember and use, just a recommend!

Regards,

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

zahord’s picture

zahord commented
StatusFileSize
new 2824443-10.patch701 bytes

Updated!

zahord’s picture

zahord commented
Status: Needs work » Needs review

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

madhu_h’s picture

madhu_h commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2021-09-27 at 4.48.27 PM.png239.73 KB
new Screenshot 2021-09-27 at 4.48.43 PM.png669.83 KB

Verified and tested the Merge request !
https://www.drupal.org/files/issues/2824443-10.patch


Testing Steps:

# Setup Languages on a site
# Add Simple-english language to the site
#verify that key for the Simple English is updated from 'en-x-simple' to 'enx'.

Test Results:
Verified that key for the Simple English is updated from 'en-x-simple' to 'enx' after applying the patch

Refer SS
https://www.drupal.org/files/issues/2021-09-27/Screenshot%202021-09-27%2...
https://www.drupal.org/files/issues/2021-09-27/Screenshot%202021-09-27%2...
Test Status: PASS

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

The original post still doesn't really explain why we need to change the key - this doesn't make any visible difference in the installer, nor can I think of a case where you need to know or remember the language key.

Also, what happens to existing sites that use Simple English? Simply changing the key will have side effects for these sites.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Closed (won't fix)
Issue tags: -language-base, -Usability

There have been 2 requests here asking for why this change is useful, one 9 years ago and again about 5 years ago. There has been no answer. @longwave, points out that the key doesn't affect the installer and that changing the key will impact existing sites. Given that and the lack of interest here I am closing this issue.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.