CommentFileSizeAuthor
#15 fix-non-token-args-2824359-15.patch706 bytessidgrafix
#9 2824359-9.patch706 bytessuresh prabhu parkala
#7 non-token-args-2824359-7.patch709 bytesalexdoma
#2 non-token-args-2824359-2.patch755 byteskducharm

Comments

kducharm created an issue. See original summary.

kducharm’s picture

kducharm commented
StatusFileSize
new non-token-args-2824359-2.patch755 bytes

Patch to handle empty $matches

kducharm’s picture

kducharm commented
Status: Active » Needs review
mitsuroseba’s picture

mitsuroseba commented
Status: Needs review » Reviewed & tested by the community

Works for me.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

We have a nice test coverage for this feature so let's please add tests for this.

patrickmichael’s picture

patrickmichael commented

Works for me.

alexdoma’s picture

alexdoma commented
StatusFileSize
new non-token-args-2824359-7.patch709 bytes

Just update patch for the new drupal versions

ConradFlashback’s picture

ConradFlashback commented

I used a global:null in view contextual filter with a static numeric default value and the token {{ arguments.null }} in contextual filter views field view field.

suresh prabhu parkala’s picture

suresh prabhu parkala commented
Status: Needs work » Needs review
StatusFileSize
new 2824359-9.patch706 bytes

Patch did not apply. Here is a re-rolled patch.

4kant’s picture

4kant commented

#9 works for me.
Thank you!

alabandit’s picture

alabandit commented

#9 works for me too. Thank you.

menelai’s picture

menelai commented
Issue summary: View changes

#9 works for me too. Thank you.

abenguyen’s picture

abenguyen commented

#9 Patch works for me too. Thanks!

gaddman’s picture

gaddman commented
Status: Needs review » Reviewed & tested by the community

#9 works a treat for me, marking as reviewed.

sidgrafix’s picture

sidgrafix commented
StatusFileSize
new fix-non-token-args-2824359-15.patch706 bytes

Here is a patch that will apply to 8.x-1.0-beta5 if anyone else wants/needs it..