Make Settings tray work with other things besides "Quick Edit" on blocks [#2822965]

Problem/Motivation

Currently Settings Tray only works for:

blocks
via a contextual link (only outside_in.block_configure, even)

Use cases:

Proposed resolution

TBD

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#3	drupal-allow_editmode_without_blocks_permission-2822965-3.patch	3.59 KB	josebc
#3	8.3.x: PHP 5.5 & MySQL 5.5 21,103 pass PHP 5.6 & MySQL 5.5 21,103 pass PHP 7 & MySQL 5.5 19,361 pass PHP 5.5 & PostgreSQL 9.1 21,099 pass PHP 5.5 & SQLite 3.8 21,098 pass PHP 7 & PostgreSQL 9.1 19,357 pass PHP 7 & SQLite 3.14 19,356 pass
#2	drupal-allow_editmode_without_blocks_permission-2822965-2.patch	1.38 KB	josebc
#2	8.3.x: PHP 5.5 & MySQL 5.5 21,094 pass, 3 fail PHP 5.5 & PostgreSQL 9.1 21,090 pass, 3 fail PHP 5.5 & SQLite 3.8 21,089 pass, 3 fail PHP 5.6 & MySQL 5.5 21,094 pass, 3 fail PHP 7 & MySQL 5.5 19,352 pass, 3 fail PHP 7 & PostgreSQL 9.1 19,348 pass, 3 fail PHP 7 & SQLite 3.14 19,347 pass, 3 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

28 October 2016 at 19:07

tedbow created an issue. See original summary.

Comment #2

josebc CreditAttribution: josebc at Vardot commented 16 November 2016 at 17:25

Status:

Active

» Needs review

File	Size
drupal-allow_editmode_without_blocks_permission-2822965-2.patch	1.38 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,094 pass, 3 fail PHP 5.5 & PostgreSQL 9.1 21,090 pass, 3 fail PHP 5.5 & SQLite 3.8 21,089 pass, 3 fail PHP 5.6 & MySQL 5.5 21,094 pass, 3 fail PHP 7 & MySQL 5.5 19,352 pass, 3 fail PHP 7 & PostgreSQL 9.1 19,348 pass, 3 fail PHP 7 & SQLite 3.14 19,347 pass, 3 fail

Patch with new permission and changed the code in isApplicable to use it

File	Size
drupal-allow_editmode_without_blocks_permission-2822965-3.patch	3.59 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,103 pass PHP 5.6 & MySQL 5.5 21,103 pass PHP 7 & MySQL 5.5 19,361 pass PHP 5.5 & PostgreSQL 9.1 21,099 pass PHP 5.5 & SQLite 3.8 21,098 pass PHP 7 & PostgreSQL 9.1 19,357 pass PHP 7 & SQLite 3.14 19,356 pass

Comment #4

16 November 2016 at 18:04

The last submitted patch, 2: drupal-allow_editmode_without_blocks_permission-2822965-2.patch, failed testing.

Comment #5

josebc CreditAttribution: josebc at Vardot commented 19 November 2016 at 12:12

1 file was hidden/shown/deleted

File	Size
drupal-allow_editmode_without_blocks_permission-2822965-2.patch	1.38 KB
8.3.x: PHP 5.5 & MySQL 5.5 21,094 pass, 3 fail PHP 5.5 & PostgreSQL 9.1 21,090 pass, 3 fail PHP 5.5 & SQLite 3.8 21,089 pass, 3 fail PHP 5.6 & MySQL 5.5 21,094 pass, 3 fail PHP 7 & MySQL 5.5 19,352 pass, 3 fail PHP 7 & PostgreSQL 9.1 19,348 pass, 3 fail PHP 7 & SQLite 3.14 19,347 pass, 3 fail

Comment #6

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Acquia commented 22 November 2016 at 14:01

Status:

Needs review

» Needs work

@josebc sorry maybe I was wrong in how I framed the problem.

I am not sure on the solution here but I don't think adding another permission will make things clearer. If a role has permission to "Administer Blocks" it would not be clear that if you enable this module that you then have to give another permission just to let them edit blocks with a different link.

Not sure of the solution. Right now "Edit mode" is actually tied to blocks. What would "Edit mode" mean if it weren't about editing blocks?

Comment #7

24 November 2016 at 10:14

The last submitted patch, 2: drupal-allow_editmode_without_blocks_permission-2822965-2.patch, failed testing.

Comment #8

josebc CreditAttribution: josebc at Vardot commented 24 November 2016 at 10:40

@tedbow, I'm currently using outside in with entityqueue so yes i agree that this should not be related to blocks since this is only a part of what this module should cover, what i was trying to do is making something similar to contextual links wich actually defines a permission of its own.
Any suggestions are welcomed here since we cannot keep it using the "administer blocks"

Comment #9

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Acquia commented 24 November 2016 at 14:25

@tedbow, I'm currently using outside in with entityqueue

Do you mean you are using the tray or actual edit mode? How are you using it?
Have you seen this issue? #2784443: Move off-canvas functionality from Settings tray module into drupal.dialog.ajax library so that other modules can use it

You should still be able to use the tray even without "administrer blocks"

Comment #10

24 November 2016 at 14:25

Version:

8.3.x-dev

» 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #11

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 19 July 2017 at 16:25

Comment #12

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 19 July 2017 at 16:42

Title:	Allow links to use Edit mode without the user having "administer blocks" permissions	» Make Settings tray work with other things besides "Configure block" on blocks
Category:	Task	» Feature request
Status:	Needs work	» Postponed

See #2762505: Introduce "outside in" quick edit pattern to core and https://www.drupal.org/core/experimental — we're working to make Settings Tray stable by 8.4.0. For now, Settings Tray is designed to work with Blocks only. Therefore this is a feature request we'll consider in the future given sufficient demand.

In the mean time, #2784443: Move off-canvas functionality from Settings tray module into drupal.dialog.ajax library so that other modules can use it should land very soon, and that will allow contrib modules to provide something similar until Settings Tray's capabilities/APIs are expanded.

Comment #13

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers at Acquia commented 19 July 2017 at 17:38

Title:	Make Settings tray work with other things besides "Configure block" on blocks	» Make Settings tray work with other things besides "Quick Edit" on blocks
Issue summary:	View changes

#2822969: Allow non-contextual links to trigger Settings Tray "Edit" mode only makes sense if we do this. Closed as duplicate.

IS updated.

Comment #14

19 July 2017 at 17:38

Version:

8.4.x-dev

» 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Comment #15

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Acquia commented 30 August 2017 at 20:04

Component:

outside_in.module

» settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)

Comment #16

30 August 2017 at 20:04

Version:

8.5.x-dev

» 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.