Closed (fixed)
Project:
Drupal core
Version:
8.3.x-dev
Component:
plugin system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Oct 2016 at 16:12 UTC
Updated:
22 Feb 2017 at 21:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
tim.plunkettComment #4
tstoecklerI realize that this is just a
@seeand not runtime code, but nevertheless we should not be introducing knowledge about Drupal's config system to the plugin component. That is just unnecessary coupling. If we want this, it should be in a separate interface in\Drupal\Core\Config.Comment #5
tim.plunkettHonestly this is such a niche concept, IMO it's really only useful for derivative when the deriver knows things the plugin doesn't.
Otherwise, \Drupal\Component\Plugin\DependentPluginInterface::calculateDependencies() should be used instead.
Therefore, moving this to a trait and new interface.
Comment #6
jibranThis makes sense.
Comment #7
xjmNote that issues like this should be targeted against 8.4.x, but can be considered for backport once they are committed to that branch. See the updated alpha release policy. Thanks!
Comment #8
tim.plunkett@effulgenstia pointed out this was missing explicit test coverage, and that it is a bug (since the code in HEAD would fatal due to no is_array() check).
Comment #10
effulgentsia commentedTicking credit boxes for reviewers.
Comment #13
effulgentsia commentedThanks! Pushed to 8.4.x. And cherry picked to 8.3.x, because this is a low-disruption bug fix.