After adding the Language button to CKEditor, descriptions of the configuration of this part have a broken link.
"six official languages of the UN" linked to http://www.un.org/en/aboutun/languages.shtml , but that page does not exist.
I think the phrase should be links to this address: http://www.un.org/en/sections/about-un/official-languages/

CommentFileSizeAuthor
#16 broken_link_in_description_CKEditor_2820979_16.patch1.02 KBlomasr
#14 2806179_14.patch591 byteslomasr
#11 broken_link_in_description_CKEditor_2820979_11.patch1.37 KBlomasr
#9 2820979-9.patch1.4 KBanish.a
#6 2820979-6.patch1.42 KBlomasr
#5 broken_link_in_description_CKEditor_2820979_5.patch1.05 KBarunkumark
#3 2820979-fix-link-to-un-site.patch1.05 KBicicleking
CKEditor plugin settings - Language.png80.81 KBjaiiali

Comments

jaiiali created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Language descriptions of "CKEditor plugin settings" have a broken link » Broken link in description of CKEditor language plugin
Version: 8.2.1 » 8.2.x-dev
Priority: Normal » Minor
Issue tags: +Quickfix, +Novice, +php-novice

Sigh, apparently the UN is not smart enough to avoid linkrot :/ This definitely used to work at some point!

Anyway, this makes for an excellent novice issue :)

icicleking’s picture

icicleking commented
StatusFileSize
new 2820979-fix-link-to-un-site.patch1.05 KB

Here is a patch that changes the link.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented

Make it HTTPS even.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Active » Needs review
Issue tags: -Novice, -php-novice
StatusFileSize
new broken_link_in_description_CKEditor_2820979_5.patch1.05 KB

As per comment #4 rerolled path with HTTPS for the link of previous patch.

lomasr’s picture

lomasr commented
StatusFileSize
new 2820979-6.patch1.42 KB

Applied the patch , it worked cleanly . I have a suggestion , as the previous link is not working , may be current link will be changed in future . I think we can include Wikipedia link (https://en.wikipedia.org/wiki/Official_languages_of_the_United_Nations) instead of UN official site link. Added a patch please review. Thanks

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Hm, I'm not sure why we're wrapping it in a Url::fromUri() call. AFAIK that's not necessary at all. I know it already was there, but let's simplify that while we're touching this code anyway.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work
anish.a’s picture

anish.a commented
Status: Needs work » Needs review
StatusFileSize
new 2820979-9.patch1.4 KB

Removed Url::fromUri()

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

I wanted to RTBC, but now noticed this:

<a href=":url">six official languages of the UN (wikipedia list)</a>.

Why add that (wikipedia list) suffix?

  1. That's not relevant information for the reader.
  2. It's not spelled correctly
  3. It breaks existing translations

Please revert that change. The only thing we should change here, is the URL. The text must stay the same.

lomasr’s picture

lomasr commented
StatusFileSize
new broken_link_in_description_CKEditor_2820979_11.patch1.37 KB

as per suggestion in #10 . Made the changes. Adding the patch. Please review Thanks.

lomasr’s picture

lomasr commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work 
-      '#description' => $this->t('The list of languages to show in the language dropdown. The basic list will only show the <a href=":url">six official languages of the UN</a>. The extended list will show all @count languages that are available in Drupal.', [
…
+      '#description' => $this->t('The list of languages to show in the language dropdown. The basic list will only show the <a href=":url">six official languages of the UN </a>. The extended list will show all @count languages that are available in Drupal.', [

This line is still being changed (a space is still being added). That line should not be changed at all.

So very close! :)

lomasr’s picture

lomasr commented
StatusFileSize
new 2806179_14.patch591 bytes

Sorry wrong patch added.

lomasr’s picture

lomasr commented
lomasr’s picture

lomasr commented
StatusFileSize
new broken_link_in_description_CKEditor_2820979_16.patch1.02 KB

Thanks for noticing the space. Resubmitted the right patch . Please review.

lomasr’s picture

lomasr commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Thanks.

  • catch committed 48dbd8f on 8.3.x 
    Issue #2820979 by lomasr, icicleking, arunkumark, anish.a, jaiiali, Wim...

  • catch committed 3e63126 on 8.2.x 
    Issue #2820979 by lomasr, icicleking, arunkumark, anish.a, jaiiali, Wim...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Fixed an un-used use statement on commit.

Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.