Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After adding the Language button to CKEditor, descriptions of the configuration of this part have a broken link.
"six official languages of the UN" linked to http://www.un.org/en/aboutun/languages.shtml , but that page does not exist.
I think the phrase should be links to this address: http://www.un.org/en/sections/about-un/official-languages/
Comment | File | Size | Author |
---|---|---|---|
#16 | broken_link_in_description_CKEditor_2820979_16.patch | 1.02 KB | lomasr |
#11 | broken_link_in_description_CKEditor_2820979_11.patch | 1.37 KB | lomasr |
#9 | 2820979-9.patch | 1.4 KB | anish.a |
#5 | broken_link_in_description_CKEditor_2820979_5.patch | 1.05 KB | arunkumark |
#3 | 2820979-fix-link-to-un-site.patch | 1.05 KB | icicleking |
Comments
Comment #2
Wim LeersSigh, apparently the UN is not smart enough to avoid linkrot :/ This definitely used to work at some point!
Anyway, this makes for an excellent novice issue :)
Comment #3
icicleking CreditAttribution: icicleking as a volunteer and at Last Call Media commentedHere is a patch that changes the link.
Comment #4
anavarreMake it HTTPS even.
Comment #5
arunkumarkAs per comment #4 rerolled path with HTTPS for the link of previous patch.
Comment #6
lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedApplied the patch , it worked cleanly . I have a suggestion , as the previous link is not working , may be current link will be changed in future . I think we can include Wikipedia link (https://en.wikipedia.org/wiki/Official_languages_of_the_United_Nations) instead of UN official site link. Added a patch please review. Thanks
Comment #7
Wim LeersHm, I'm not sure why we're wrapping it in a
Url::fromUri()
call. AFAIK that's not necessary at all. I know it already was there, but let's simplify that while we're touching this code anyway.Comment #8
Wim LeersComment #9
anish.a CreditAttribution: anish.a at Axelerant commentedRemoved
Url::fromUri()
Comment #10
Wim LeersI wanted to RTBC, but now noticed this:
Why add that
suffix?Please revert that change. The only thing we should change here, is the URL. The text must stay the same.
Comment #11
lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedas per suggestion in #10 . Made the changes. Adding the patch. Please review Thanks.
Comment #12
lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedComment #13
Wim LeersThis line is still being changed (a space is still being added). That line should not be changed at all.
So very close! :)
Comment #14
lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedSorry wrong patch added.
Comment #15
lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedComment #16
lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedThanks for noticing the space. Resubmitted the right patch . Please review.
Comment #17
lomasr CreditAttribution: lomasr at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commentedComment #18
Wim LeersThanks.
Comment #21
catchFixed an un-used use statement on commit.
Committed/pushed to 8.3.x and cherry-picked to 8.2.x. Thanks!