Closed (fixed)
Project:
Stage File Proxy
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Oct 2016 at 23:57 UTC
Updated:
18 Apr 2017 at 23:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
geek-merlinPatch flying in that should fix this.
Comment #3
geek-merlinThis works on my site.
Comment #4
gregglesThis line seems odd:
You want to be really sure the $server variable is set? ;)
Comment #5
geek-merlinOh, lol... Seems the IDE was in WET mode, so no DRY code...
Fixed the fix...
Comment #6
asrobAs axel.rutz says, it works for me as well. Thanks for this patch, Axel!
Comment #8
gregglesThanks for the patch and review! Now applied.
I made a slight tweak to the comment to make it more clear where/why https is being ignored.
Does this apply to 8.x?
Comment #9
asrob@greggles,
Yes, I've successfully applied to 8.x.
Comment #11
greggles@asrob successfully applied what to 8.x? the patch as it stands certainly doesn't apply. Did you mean to upload something?
Comment #12
asrob@greggles,
oops, sorry. You're right, it does not work in 8.x. I did not remember correctly because I've tested another patches for 8.x.
Comment #13
geek-merlinComment #14
geek-merlinPatch flying in for 8.
Some straightforward preliminary code fix was needed.
Comment #15
geek-merlinOk the last file contained clean 2 git patches which git has no problem with.The cweagans composer-patches plugin has, so here the same squashed to 1 patch.
So #14 is the proposal to commit and this #15 for compatibility. Sigh.
EDIT: Nope, i was in error. Forget this patch.
Comment #16
geek-merlinWe can do even better and bail out early.
Comment #17
geek-merlin...which obsoletes another if bracketing.
Comment #19
geek-merlinLooks sane and works in production.