Comments

axel.rutz created an issue. See original summary.

geek-merlin’s picture

Status: Active » Needs review
StatusFileSize
new1.11 KB

Patch flying in that should fix this.

geek-merlin’s picture

This works on my site.

greggles’s picture

This line seems odd:

+    $server = $server = rtrim(variable_get('stage_file_proxy_origin'), '/');

You want to be really sure the $server variable is set? ;)

geek-merlin’s picture

StatusFileSize
new1.1 KB

Oh, lol... Seems the IDE was in WET mode, so no DRY code...

Fixed the fix...

asrob’s picture

Status: Needs review » Reviewed & tested by the community

As axel.rutz says, it works for me as well. Thanks for this patch, Axel!

  • greggles committed 6aa4b37 on 7.x-1.x authored by axel.rutz
    Issue #2819912 by axel.rutz: Endless redirection on origin
    
greggles’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks for the patch and review! Now applied.

I made a slight tweak to the comment to make it more clear where/why https is being ignored.

Does this apply to 8.x?

asrob’s picture

@greggles,

Yes, I've successfully applied to 8.x.

  • greggles committed 218620d on 7.x-1.x authored by axel.rutz
    Issue #2819912 by axel.rutz: Endless redirection on origin
    
greggles’s picture

@asrob successfully applied what to 8.x? the patch as it stands certainly doesn't apply. Did you mean to upload something?

asrob’s picture

@greggles,

oops, sorry. You're right, it does not work in 8.x. I did not remember correctly because I've tested another patches for 8.x.

geek-merlin’s picture

Title: Endless redirection on origin » Sleep on production, to prevent endless redirection
geek-merlin’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new2.38 KB

Patch flying in for 8.

Some straightforward preliminary code fix was needed.

geek-merlin’s picture

Ok the last file contained clean 2 git patches which git has no problem with.
The cweagans composer-patches plugin has, so here the same squashed to 1 patch.
So #14 is the proposal to commit and this #15 for compatibility. Sigh.

EDIT: Nope, i was in error. Forget this patch.

geek-merlin’s picture

We can do even better and bail out early.

geek-merlin’s picture

StatusFileSize
new6.51 KB

...which obsoletes another if bracketing.

  • axel.rutz committed f32e253 on 8.x-1.x
    Issue #2819912 by axel.rutz, greggles, asrob: Sleep on production, to...
geek-merlin’s picture

Status: Needs review » Fixed

Looks sane and works in production.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.