Install profiles not sorted alphabetically

Would be good to have the possibility to set 'weights' to profiles, and sort them by weight. For example, profiles may declare their weight in the hook_details:

function default_profile_details() {
  return array(
    'name' => 'Drupal',
    'description' => 'Select this profile to enable some basic Drupal functionality and the default theme.',
    'weight' => -10, 
  );
}

That smells of feature creep to me. Is there a genuine use case for setting weights in a place that a) faces only the admin, b) is visible only once during installation, c) probably involves a very short list of profiles? Alphabetic sounds good enough to me...

webchick: Would another loop cost much performance? I could see something like this, in theory:

  foreach ($profiles as $profile) {
    include_once($profile->filename);
    // Load profile details.
    $function = $profile->name . '_profile_details';
    if (function_exists($function)) {
      $details = $function();
    }
    // If set, used [sic] defined name. Otherwise use file name.
    $name = isset($details['name']) ? $details['name'] : $profile->name;

// Split the loop here...

    $all_details[$name] = $details;
  }

  ksort($all_details);

  foreach ($all_details as $name => $details) {

// End changed code

    $form['profile'][$name] = array(
      '#type' => 'radio',
      '#value' => 'default',
      '#return_value' => $profile->name,
      '#title' => $name,
      '#description' => isset($details['description']) ? $details['description'] : '',
      '#parents' => array('profile'),
    );
  }

Probably not. I was trying to keep this as simple as possible because I *really* want it back-ported to 6.x. The source code for our book is getting displayed as like:

Chapter 04: Blah
Chapter 09: Yadda
Chapter 05: Whee

Book? I thought this issue was specifically related to install profiles?

The patch did not apply for me :(

The book we're writing (Drupal Jumpstart) comes with source code, which is a single Drupal 6 installation, a crap-ton of modules, and an install profile for each chapter to boot-strap some stuff.

Aha! Okay. The relation between books and profiles had confused me. ;)

---

Besides the custom profile I already have, I have created multiple copies of the default.profile: atrus, gandalf and zebra. atrus.profile has a name of "Profile Atrus" to distinguish human name from system name, the others are named by their file names.

Pre-patch:

- Gandalf
- Profile Atrus
- Zebra
- Ermarian Network
- Drupal

Looks kind of random.

Post-patch:

- Drupal
- Ermarian Network
- Gandalf
- Profile Atrus
- Zebra

And on 7.x:

- Zebra
- Gandalf
- Profile Atrus
- Small Business
- Ermarian Network
- Drupal

Post-patch:

- Drupal
- Ermarian Network
- Gandalf
- Profile Atrus
- Small Business
- Zebra

Looks good (though perhaps Dries wants a second review).

Tested the 7.x patch and works as expected. So, confirm RTBC.

I've tested and reviewed these patches and they look good. I've committed it to DRUPAL-6 and CVS HEAD. Thanks all.