WSOD when using invalid tokens in action [#2817683]

A WSOD is shown when a system.mail action is triggered, containing invalid/not available tokens in the mail message body.

Casus: send an notification mail when a new comment is posted.

Steps to reproduce:
- Add new rule "rules_entity_insert:comment" (After saving new comment)
- no conditions per se
- add action "system > send email"
- add a token thats not available like "{{site.url}}" to the message body field
- trigger the action by submitting a comment

Comment	File	Size	Author
#6	2817683-wsod-invalid-tokens-get.patch	672 bytes	swim
#6	8.x-3.x: PHP 7.1 & MySQL 5.5, D8.4 271 pass, 2 fail PHP 5.5 & MySQL 5.5, D8.7 277 pass, 2 fail PHP 7.2 & MySQL 5.5, D8.7 277 pass, 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

13 October 2016 at 09:57

keesje created an issue. See original summary.

Comment #2

swim CreditAttribution: swim commented 30 August 2017 at 02:14

Please see, https://github.com/fago/rules/pull/487; as a potential solution.

Comment #3

swim CreditAttribution: swim commented 30 August 2017 at 02:14

Status:

Active

» Needs review

Comment #4

TR CreditAttribution: TR commented 12 November 2017 at 10:16

Status:

Needs review

» Active

I can confirm that following the above steps leads to a WSOD.

Moving to "Active" status as there is no patch to review yet.

Comment #5

TR CreditAttribution: TR commented 12 November 2017 at 10:24

I closed #2862768: [comment:edit-url] : Undefined Variable, which was reporting the same error with the invalid (D7-style tokens) [site:mail], [comment:body], and [comment:edit-url]

Comment #6

swim CreditAttribution: swim commented 11 December 2017 at 03:53

Status:

Active

» Needs review

File	Size
2817683-wsod-invalid-tokens-get.patch	672 bytes
8.x-3.x: PHP 7.1 & MySQL 5.5, D8.4 271 pass, 2 fail PHP 5.5 & MySQL 5.5, D8.7 277 pass, 2 fail PHP 7.2 & MySQL 5.5, D8.7 277 pass, 2 fail

Sorry I thought all dev work was happening on github :S, please find attached.

Comment #7

fago

German

Vienna

CreditAttribution: fago at drunomics commented 14 December 2017 at 16:19

Status:

Needs review

» Needs work

Test seems to fail? Anyway, I think we should add a test case to proof this works now even with invalid tokens.

Comment #8

TR CreditAttribution: TR commented 22 August 2018 at 04:41

These are real test failures - that is, the patch changed the message Rules outputs when there is an invalid token, and the test is still looking for the 'old' message.

Personally, I think the 'old' message, which is Data selector <em class="placeholder">list_item</em> for context <em class="placeholder">Text to concatenate</em> is invalid. Unable to get variable list_item, it is not defined. is a LOT more descriptive and useful than the new message after the patch, which is Undefined index: list_item.

Regardless, the module output has to match what the string is testing for. The test failure happens in Drupal\Tests\rules\Unit\Integration\Engine\LoopTest::testOutOfScopeVariableExecution()