Installed the module and it works fine for at least Twitter and Instagram.

But the Facebook tag is not generating the proper content.

For example:
[facebook]https://www.facebook.com/username/posts/postnumber[/facebook]
gets translated into:
<div class="fb-post" data-href="https://www.facebook.com/username/posts/postnumber"></div>
without any detailed content within the div.

As mentioned above, the other shortcodes are working fine.

CommentFileSizeAuthor
#4 facebook_shortcode_not-2817547-4.patch1.11 KBliampower

Comments

Carlos Miranda Levy created an issue. See original summary.

Carlos Miranda Levy’s picture

Carlos Miranda Levy commented
Issue summary: View changes
liampower’s picture

liampower commented

Hi Carlos,

Thank you for creating this issue. I am aware of Facebook embeds not currently working. The reason for this is the Facebook JS is currently not included as I've not had time to look in to the best way of importing it yet, in 7 this was done through hook_page_build.

The Javascript needed is: 

(function(d, s, id) {
      var js, fjs = d.getElementsByTagName(s)[0];
      if (d.getElementById(id)) return;
      js = d.createElement(s); js.id = id;
      js.src = "//connect.facebook.net/en_US/sdk.js#xfbml=1&version=v2.2";
      fjs.parentNode.insertBefore(js, fjs);
    }(document, 'script', 'facebook-jssdk'));
liampower’s picture

liampower commented
Status: Active » Needs review
StatusFileSize
new facebook_shortcode_not-2817547-4.patch1.11 KB

It would appear Facebook added support for oEmbed so I have made a patch to update to using this instead.

liampower’s picture

liampower commented

I'm going to commit patch #4 and so I can release 8.x-1.0-beta1

  • LiamPower committed 44ec076 on 8.x-1.x 
    Issue #2817547 by LiamPower: Facebook shortcode not working on 8.x
liampower’s picture

liampower commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Released. Patch to be ported to the Drupal 7 version as it is a nicer implementation.

  • LiamPower committed 73d41d2 on 7.x-1.x 
    Issue #2817547 by LiamPower: Facebook shortcode not working on 8.x...
liampower’s picture

liampower commented
Status: Patch (to be ported) » Fixed

Backported to 7.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.