After update to Drupal Core 8.2 I wasn't able to insert IMAGES into CKEditor via IMAGE button:
screenshot

CommentFileSizeAuthor
#13 simple_image_popup-module-broken-by-patch-in-inline_responsive_image.png40.78 KBCarlos Miranda Levy
#2 inline-responsive-image-ckeditor-insert-ajax-bug-2816745-2-d8.patch840 bytesveronicaseveryn
Screen Shot 2016-10-11 at 2.19.20 PM.png244.3 KBveronicaseveryn

Comments

veronicaSeveryn created an issue. See original summary.

veronicaseveryn’s picture

veronicaseveryn commented
StatusFileSize
new inline-responsive-image-ckeditor-insert-ajax-bug-2816745-2-d8.patch840 bytes

Uploading a patch that fixes the bug.

veronicaseveryn’s picture

veronicaseveryn commented
Status: Active » Needs review
jon@s’s picture

jon@s commented
Status: Needs review » Reviewed & tested by the community

Can confirm this fixed the bug for me (8.2.1) without any problems.

afoster’s picture

afoster commented

Second Confirmation this patch worked in 8.2.1 - Thank you @veronicaSeveryn !

gedvan’s picture

gedvan commented

The patch also worked fine for me in 8.2.1. Thanks!

norwegian.blue’s picture

norwegian.blue commented

Confirm that it fixed the issue for me too in 8.2.1 - Thanks for the work.

  • jeroen_betawerk committed 9f4c2c3 on 8.x-2.x 
    Issue #2816745 by veronicaSeveryn: fixed incompatibility with Drupal 8.2
jeroen_vreuls’s picture

jeroen_vreuls commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch veronicaSeveryn. It has been committed to the dev version.

ukor’s picture

ukor commented

Great work, veronicaSeveryn! Works on 8.2.1 in my environment.
Thanks a lot.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Carlos Miranda Levy’s picture

Carlos Miranda Levy commented

Patch works, upgrading to dev solves the issue for this module.

Unfortunately, it breaks the Simple Image Popup module -- https://www.drupal.org/project/image_popup -- which starts to display the same behavior (Loading...) as soon as the patch/dev version of inline_responsive_image is installed.

While we could argue that it then becomes a problem for image_popup, I suspect that this fix will probably break other modules, so perhaps we should review it.

Carlos Miranda Levy’s picture

Carlos Miranda Levy commented
StatusFileSize
new simple_image_popup-module-broken-by-patch-in-inline_responsive_image.png40.78 KB