In #2010898: Use tokens for entity selection view arguments/#1699378: Allow tokens in entity reference views selection arguments I assumed that this was by design, but comment #94 suggested that this would be better off being handled by views.
axel.rutz:
an empty string should be passed which views should treat as unavailable argument (if not please file an issue about that).
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | views-n281586314.patch | 561 bytes | damienmckenna |
| #14 | views-n281586314.interdiff.txt | 594 bytes | damienmckenna |
| #12 | views-2815863-12.patch | 522 bytes | mustanggb |
Comments
Comment #2
mustanggb commentedTesting this out.
Comment #3
mustanggb commentedComment #4
mustanggb commentedAfter initial testing I've not experienced any adverse effects thus far.
Comment #5
minoroffense commentedTo avoid warning messages don't we need an "isset() and !empty()" in there? Otherwise if the value key is missing altogether we'll get a different warning, no?
Comment #6
mustanggb commentedSource: http://php.net/manual/en/function.empty.php
Comment #7
minoroffense commentedRight. Duh me.
Comment #8
stupiddingo commentedReroll of #2, line numbers only change.
Comment #9
panchoSame issue with D8 views, so while technically a separate project, we might want to decide in D8 Core how to proceed, before backporting to D7 Views.
Comment #10
mustanggb commentedPlease create a new issue for D8.
Comment #11
pancho@MustangGB: There we go: #3027640: Empty strings ("") passed in as contextual filter argument aren't considered missing
Comment #12
mustanggb commentedAs discovered by Pancho in #3027640: Empty strings ("") passed in as contextual filter argument aren't considered missing "0" is a valid value, so new patch to use the explicit check instead.
Comment #13
damienmckennaCould you please wrap the two conditions in a bracket, to make it more clear, and add a comment explaining the logic? Thanks.
Comment #14
damienmckennaSimplified the code a little.
Comment #16
damienmckennaCommitted. Thanks.