Move message, goto, and email action plugins to Drupal\Core\Action

I think plugins should go to core instead of system

Added update hook, probably we need to resave all views which using bulk actions because some of them could use configured actions and have action module in dependencies

Only nits left

1. +++ b/core/modules/action/action.post_udate.php
   @@ -0,0 +1,26 @@
   +  \Drupal::classResolver(ConfigEntityUpdater::class)->update($sandbox, 'action', function ($action) use ($resave_ids) {
   +    /** @var \Drupal\system\ActionConfigEntityInterface $action */
   

   Nit, can use actual typehinting in the closure function ActionConfigEntityInterface $action)

2. +++ b/core/modules/action/action.post_udate.php
   @@ -0,0 +1,26 @@
   +    if ($action->isConfigurable() && in_array($action->getPlugin()->getPluginId(), $resave_ids, TRUE)) {
   ...
   +      return TRUE;
   

   This can be return ($action->isConfigurable() ...
   instead of needing an if

Now needs CR, guess upgrade tests not needed

I can confirm the patch #9 applies cleanly.

❯ d8core 8.7.x* git apply -v --index 2815379-9.patch
Checking patch core/modules/action/src/Plugin/Action/EmailAction.php => core/lib/Drupal/Core/Action/Plugin/Action/EmailAction.php...
Checking patch core/modules/action/src/Plugin/Action/GotoAction.php => core/lib/Drupal/Core/Action/Plugin/Action/GotoAction.php...
Checking patch core/modules/action/src/Plugin/Action/MessageAction.php => core/lib/Drupal/Core/Action/Plugin/Action/MessageAction.php...
Checking patch core/modules/action/action.post_udate.php...
Applied patch core/modules/action/src/Plugin/Action/EmailAction.php => core/lib/Drupal/Core/Action/Plugin/Action/EmailAction.php cleanly.
Applied patch core/modules/action/src/Plugin/Action/GotoAction.php => core/lib/Drupal/Core/Action/Plugin/Action/GotoAction.php cleanly.
Applied patch core/modules/action/src/Plugin/Action/MessageAction.php => core/lib/Drupal/Core/Action/Plugin/Action/MessageAction.php cleanly.
Applied patch core/modules/action/action.post_udate.php cleanly.

We need the upgrade path tests. We also need to deprectate the existing classes and tests for the deprecations. Just read https://www.drupal.org/core/d8-bc-policy#plugins.

guess upgrade tests not needed

Why do you think that?

Patch moves config schema & test to core as well

Filed CR https://www.drupal.org/node/3018300

@jibran which kind of upgrade tests you can suggest? I can imagine only ones that configured actions did change their dependencies

I bet this should be enough, test and fixture added to system module where other action updates live

Something like \Drupal\Tests\system\Functional\Update\UpdateActionsWithEntityPluginsTest

@jibran Anything left here?

Thanks, this is good to go.

The patch looks fine but it would be good to have a test-only patch here.

I think it's OK to just move these since plugins are @internal.

@catch do you mean this kind of patch?

Back to rtbc

Committed 281c6f0 and pushed to 8.7.x. Thanks!

published CR

The test is too strict should check only for dependencies, fixing in #2677116-26: Allow setting message type for message action plugin

Created #3053656: Rename action.post_udate.php to action.post_update.php so that the upgrade path runs correctly