In drupal_http_request(), the request body must be provided as a URL-encoded query string. It would be more convenient to be able to provide this as an array and have the function call http_build_query() on it automatically. Patch coming.

CommentFileSizeAuthor
#7 drupal-drupal_http_request_data_array-2814031-7-D7.patch2.96 KBliam morland
#4 drupal-drupal_http_request_data_array-2814031-4-D7.patch2.96 KBliam morland
#2 drupal-drupal_http_request_data_array-2814031-2-D7.patch1.34 KBliam morland

Comments

Liam Morland created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal-drupal_http_request_data_array-2814031-2-D7.patch1.34 KB
fabianx’s picture

fabianx commented
Issue tags: +Needs tests

This will need a test, I think.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: -Needs tests
StatusFileSize
new drupal-drupal_http_request_data_array-2814031-4-D7.patch2.96 KB

With tests.

Status: Needs review » Needs work

The last submitted patch, 4: drupal-drupal_http_request_data_array-2814031-4-D7.patch, failed testing.

The last submitted patch, 4: drupal-drupal_http_request_data_array-2814031-4-D7.patch, failed testing.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-drupal_http_request_data_array-2814031-7-D7.patch2.96 KB

Reroll.

fabianx’s picture

fabianx commented
Issue tags: +Drupal 7.60 target

I think we can even get this in, because Drupal 8 has guzzle, which for sure has a different syntax so we should be free to tweak things here.

Needs someone else to RTBC it, but it looks good to me on a first glance.

pol’s picture

pol
Location Brussels
commented
Status: Needs review » Reviewed & tested by the community

Nice idea and patch including tests.

Fine for me :)

pol’s picture

pol
Location Brussels
commented
Issue tags: +Pending Drupal 7 commit
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue tags: -Drupal 7.60 target +Drupal 7.61 target

Bumping to 7.61, this didn't make it into 7.60

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue tags: -Drupal 7.61 target +Drupal 7.62 target
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue tags: -Drupal 7.62 target +Drupal 7.64 target

  • Pol committed 23ae731 on 7.x 
    Issue #2814031 by Liam Morland: In drupal_http_request(), allow passing...
pol’s picture

pol
Location Brussels
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -Drupal 7.64 target, -Pending Drupal 7 commit +Drupal 7.67 target

Patch has been committed, thanks !

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks!

mustanggb’s picture

mustanggb commented

Oooh very nice.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I just realized this probably should have been drupal_http_build_query() instead of http_build_query().

pol’s picture

pol
Location Brussels
commented

Let's open a new issue and fix it :)

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

#3059391: Use drupal_http_build_query() in drupal_http_request()