Problem/Motivation

This issue is a follow up to #2811927: Disabling Content moderation on a bundle, removes the ability to perform create content on that bundle where we came to the realization that when you enable moderation all existing entity revisions get the default moderation state (often 'draft'). Then when disabling moderation all ContentModerationState entities, which stores the moderation state for other entities, just stay there. Should they?

Proposed resolution

  • When enabling moderation apply an unpublished state to all unpublished revisions and a published state to all published revisions.
  • When disabling moderation ask if they user wishes to delete all moderation state history.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

timmillwood created an issue. See original summary.

alexpott’s picture

The other option is not not allow removing moderation from a bundle once there is content under moderation.

timmillwood’s picture

@alexpott not sure I like that idea. I also feel that disabling moderation is a fairly non-issue, I think enabling moderation is more of an issue. This covers both enabling moderation initially when there are entities, and enabling it again after previously being disabled.

jojototh’s picture

I agree with the proposed resolution:

  • When enabling moderation apply an unpublished state to all unpublished revisions and a published state to all published revisions.
  • When disabling moderation ask if the user wishes to delete all moderation state history.

The disabling part is following the same pattern as uninstalling games on iOS, when user is prompted if he wishes to keep or remove game data from the iOS Game center. I think that would be a good & non-destructive UX.

catch’s picture

Priority: Normal » Major

Bumping this to major, seems important to get right.

timmillwood’s picture

timmillwood’s picture

Issue tags: +Workflow Initiative

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

timmillwood’s picture

Status: Active » Fixed

Marking as fixed because the issues in #6 are RTBC and closed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.