Problem/Motivation
This issue is a follow up to #2811927: Disabling Content moderation on a bundle, removes the ability to perform create content on that bundle where we came to the realization that when you enable moderation all existing entity revisions get the default moderation state (often 'draft'). Then when disabling moderation all ContentModerationState entities, which stores the moderation state for other entities, just stay there. Should they?
Proposed resolution
- When enabling moderation apply an unpublished state to all unpublished revisions and a published state to all published revisions.
- When disabling moderation ask if they user wishes to delete all moderation state history.
Comments
Comment #2
alexpottThe other option is not not allow removing moderation from a bundle once there is content under moderation.
Comment #3
timmillwood@alexpott not sure I like that idea. I also feel that disabling moderation is a fairly non-issue, I think enabling moderation is more of an issue. This covers both enabling moderation initially when there are entities, and enabling it again after previously being disabled.
Comment #4
jojototh commentedI agree with the proposed resolution:
The disabling part is following the same pattern as uninstalling games on iOS, when user is prompted if he wishes to keep or remove game data from the iOS Game center. I think that would be a good & non-destructive UX.
Comment #5
catchBumping this to major, seems important to get right.
Comment #6
timmillwoodI have opened #2817835: When enabling moderation apply a relative state and #2817845: When disabling moderation there is no way to remove moderation states as follow up tasks to this issue.
Comment #7
timmillwoodComment #9
timmillwoodMarking as fixed because the issues in #6 are RTBC and closed.