Problem/Motivation

The contact category migration dedupes the user_role entity instead of contact_form, the actual destination. And even that is using a field 'cid' which does not exist on the user role entity, so always return 0.

      plugin: dedupe_entity
      entity_type: user_role
      field: cid
      length: 32

Proposed resolution

Dedupe on contact_form using the id field.

      plugin: dedupe_entity
      entity_type: contact_form
      field: id
      length: 32
CommentFileSizeAuthor
#2 interdiff.txt411 bytesquietone
#2 2812625-2.patch2.08 KBquietone
#2 2812625-2-test-only.patch1.54 KBquietone

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Status: Active » Needs review
StatusFileSize
new 2812625-2-test-only.patch1.54 KB
new 2812625-2.patch2.08 KB
new interdiff.txt411 bytes

Modified the contact category migration test to force the creation of a duplicate.

The last submitted patch, 2: 2812625-2-test-only.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Good test coverage. Obviously a copy/pasta error that is getting fixed with a test.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2812625-2.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Reviewed & tested by the community

Momentary blip resulting from massive DDoS outage. Passed on retest, still RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8c813b1 to 8.3.x and 69e96b3 to 8.2.x. Thanks!

  • alexpott committed 8c813b1 on 8.3.x 
    Issue #2812625 by quietone: contact_category should dedupe contact_form...

  • alexpott committed 69e96b3 on 8.2.x 
    Issue #2812625 by quietone: contact_category should dedupe contact_form...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.