Problem:
During this commit, #2784463: Convert outside_in_page_(top|bottom)() to a #theme_wrappers, the {% spaceless %}
tag was introduced. This tag removes all the whitespace between HTML tags. It affects to almost *all* the HTML content in the page because it is used in a template that acts as a page wrapper. This only happens *IF* the outside_in module is enabled.
The spaceless tag removes whitespace that is used to add extra padding to certain UI elements, like checkbox labels, radio labels and breadcrumbs.
See screenshot.
Solution:
Remove the spaceless tag.
Twig Documentation of spaceless tag:
http://twig.sensiolabs.org/doc/tags/spaceless.html
Patch attached in #2
TODO:
Review patch.
Review spaceless tag used in other templates in Drupal core.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2810547-spaceless-1.patch | 723 bytes | corbacho |
#2 | 2810547-spaceless-1.patch | 723 bytes | corbacho |
spaceless.png | 83.74 KB | corbacho |
Comments
Comment #2
corbacho CreditAttribution: corbacho as a volunteer commentedComment #3
corbacho CreditAttribution: corbacho as a volunteer commentedComment #4
tedbowNice catch. Thanks for the patch!
Comment #6
tedbowNot sure what is going on. I see no test failure https://www.drupal.org/pift-ci-job/500299
Comment #7
corbacho CreditAttribution: corbacho as a volunteer commentedStrange. Thanks for reviewing Ted
Comment #8
corbacho CreditAttribution: corbacho as a volunteer commentedComment #9
corbacho CreditAttribution: corbacho as a volunteer commentedRe-upload
Comment #10
corbacho CreditAttribution: corbacho as a volunteer commentedComment #11
corbacho CreditAttribution: corbacho as a volunteer commentedComment #14
star-szrCommitted and pushed 4f6dc7b to 8.3.x and c2fff6f to 8.2.x. Thanks!
Comment #15
tedbow@Cottser Thanks!
Comment #16
corbacho CreditAttribution: corbacho as a volunteer commentedThank you Ted and Cottser
Comment #18
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)