As per my suggestion , we can increase the usability of this module by adding "Permission type Dropdown".

So that we can filter data as per our requirement :

1: All Permissions :- Hear we can show All permission side by side.
2: Matched Permission :- Hear we can show only matched permission.
3: Diff Permission :- Hear we can show permission diff side by side.

Also we can provide download csv for every filter page.

CommentFileSizeAuthor
#4 issue-2810445.jpg78.89 KBbenwitters
#4 permission_type_dropdown-2810445-4.patch3.58 KBbenwitters

Comments

poojasharmaece created an issue. See original summary.

visabhishek’s picture

visabhishek commented
Issue tags: +Novice
benwitters’s picture

benwitters commented

I am working on this issue.

benwitters’s picture

benwitters commented
Status: Active » Needs review
StatusFileSize
new permission_type_dropdown-2810445-4.patch3.58 KB
new issue-2810445.jpg78.89 KB

I created the extra dropdown functionality to filter the permission data (All, matched and different permissions). Let me know what you think of the result.

visabhishek’s picture

visabhishek commented

Thanks Ben, I will review the patch and commit.

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Needs work

@benwitters, Thanks for the patch but i don't think so that it filters the correct results for administrator role, as i tested i conclude with it. Let me know if i'm wrong.

benwitters’s picture

benwitters commented
Status: Needs work » Needs review

@dhwani.addweb this is true but has nothing to do with this patch because the problem you are refering to was already there on the original dev branch. This problem should be handled on a new issue.

sandeepguntaka’s picture

sandeepguntaka commented
Status: Needs review » Reviewed & tested by the community

The patch works great. Thanks @benwitters for the patch and @dhwani.addweb for testing.

  • visabhishek committed 66ebd0d on 8.x-1.x authored by benwitters 
    Issue #2810445 by benwitters, poojasharmaece, visabhishek, dhwani.addweb...
visabhishek’s picture

visabhishek commented
Status: Reviewed & tested by the community » Fixed

Thanks benwitters for the patch and dhwani , sandeepreddyg for testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.