Problem/Motivation

Typo for Xss::filterAdmin in as Xss::adminFilter

Proposed resolution

Change doc to the correct Xss::filterAdmin

CommentFileSizeAuthor
#3 2809853-1.patch657 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Reviewed & tested by the community

Self RTBC because it's impossible to get this wrong.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 2809853-1.patch657 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

@joelpittet the problem with self-rtbc's is that is teaches bad habits. Also:

Self RTBC because it's impossible to get this wrong.

Well we got it wrong once before :)

The fix is correct but now I can't commit because this hasn't been through community process. There are other instances of Xss::adminFilter in core.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Project wide search for 'adminFilter' doesn't turn up any other instances of this for me.

Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 88ba3b9 to 8.3.x and 56188d7 to 8.2.x. Thanks!

  • alexpott committed 88ba3b9 on 8.3.x 
    Issue #2809853 by joelpittet: Xss::filterAdmin() typo

  • alexpott committed 56188d7 on 8.2.x 
    Issue #2809853 by joelpittet: Xss::filterAdmin() typo

(cherry picked...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.