Hi TWG!

Can you check #2802947: [meta] Use the Git commit message format from AngularJS?

That change of standards would affect all of core and contrib, so it should have your blessing :)

Comments

klausi created an issue. See original summary.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented

Copying my comment from #2802947-5: [meta] Use the Git commit message format from AngularJS.

-------------------------------------------------------------

Instead of putting everything inside the commit summary, few things can be put inside the commit description.

Like this:

fix(phpunit): set SIMPLETEST_USER_AGENT every 5s

Issue #2771547 by Lendude, klausi, dawehner, alexpott, pwolanin

More info:
- In Browser and FunctionalJavascript tests SIMPLETEST_USER_AGENT cookie needs to be set every 5 seconds

Commit message based on this template:

Capitalized, short (50 chars or less) summary

Issue #NUMBER by CREDITS

More info (optional):
- Info 1
- Info 2

We can then program the Bot to parse the third line of commit and give credits to the user.

This way the commit summary looks cleaner.

Reference:
- http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
- http://chris.beams.io/posts/git-commit

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

This issue is just about changing the arrangement of our single line git commit messages, please discuss multiple lines for git commit messages in #2811033: Discuss if git commit messages should be multiple lines.

jthorson’s picture

jthorson commented
Status: Active » Fixed

Discussed during our meeting on January 31st, 2017, and feedback provided in #2802947-31: [meta] Use the Git commit message format from AngularJS.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.