Problem/Motivation

Recently we added the function to select the theme used for comparing revisions with the visual inline plugin. But the update function is missing from previous versions.

Proposed resolution

Add a new update function.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 diff_2809485_init_4.patch458 bytesmiro_dietiker
#2 provide_update_function-2809485-2.patch674 bytesjohnchque

Comments

yongt9412 created an issue. See original summary.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Related issues: +#2799597: Select theme for diff display
StatusFileSize
new provide_update_function-2809485-2.patch674 bytes

This is missing.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Active » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new diff_2809485_init_4.patch458 bytes 
+++ b/diff.install
@@ -106,3 +106,17 @@ function diff_update_8006() {
+  $visual_inline = $layout_manager->hasDefinition('visual_inline');
+  if ($visual_inline) {
+    $config->set('general_settings.visual_inline_theme', 'standard');

This reminds me that other code can result in a problem.

If on update the plugin is not available, later the classes are available, the setting is still not initialised.

The config always initialises the value in default config, thus we should always set it in update.
Dropped conditions. Attaching patch.

  • miro_dietiker committed f440977 on 8.x-1.x 
    Issue #2809485 by yongt9412, miro_dietiker: Provide update function for...
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed like that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.