Remove content type diff view mode setting

+++ b/src/DiffBuilderManager.php
@@ -137,7 +137,7 @@ class DiffBuilderManager extends DefaultPluginManager {
+      $view_mode = $this->config->get($field_definition->getTargetEntityTypeId() . $target_bundle . '.view_mode');

I think there is a '.' between the targetentitytypeid and the targebundle.

Added dot as suggested in previous comment.

Had some discussion with @berdir, unfortunately tests fails and i am not sure how to fix it. ALso made some changes regarding comment #7.

+++ b/src/DiffBuilderManager.php
@@ -137,7 +137,7 @@ class DiffBuilderManager extends DefaultPluginManager {
+     $view_mode = $this->config->get('bundle_settings' . '.' . $field_definition->getTargetEntityTypeId() . '.' . $target_bundle . '.view_mode');

don't use the getTargetEntityTypeId() here, just use the target bundle.

#10 is wrong. That is actually the only call that is correct, all the others and the schema is wrong.

+++ b/src/DiffBuilderManager.php
@@ -137,7 +137,7 @@ class DiffBuilderManager extends DefaultPluginManager {
+     $view_mode = $this->config->get('bundle_settings' . '.' . $field_definition->getTargetEntityTypeId() . '.' . $target_bundle . '.view_mode');

Don't change the indentation here please. :)

We might need an update function for this config change.

+++ b/config/schema/diff.schema.yml
@@ -43,16 +43,19 @@ diff.settings:
+        type: sequence
+        label: 'Target bundle'
+        sequence:
+          type: mapping
+          label: 'Content type'

target bundle and content type is the same thing. The first level is the *entity type*.

And yeah, we need to update the existing configuration. Another question is that we now change the structure to theoretically support other entity types. But we actually don't do that yet. Not sure if we should do that her or in another issue. another issue might be better as that won't be trivial (likely needs its own form that lists all relevant entity types and their bundles, similar to share message/like_and_dislike) as we can't reliably alter any bundle form out there.

Seems to be to have in diff a list of the view modes set for nodes. We can remove it as far as I can see. But this will make changes in getSelectedPluginForFieldDefinition, needs to be investigated.

Had some discussion with @berdir, he suggested to create update config function and to create follow up (in revision section it should be loaded from settings view mode, as i understood :) ). Some small fies in patch and create update config function...

Even if we do remove the check that we have now, using this setting for the default view view mode in the visual diff might be useful as some entity/node types are really only used certain view modes. Not strong feelings, though.

Removed view mode filed, created update config function and fixed some tests. Let see the test bot...

Removed the whole setting. Now using the default form display. :)