When trying to sync taxonomy term, in webfactory/webfactory_slave/src/EntitySyncWrapper.php, getTitle(), the field is hardcoded and the title for taxonomy term is 'name' not 'title'.

CommentFileSizeAuthor
#2 2805257-2-taxonomy-term-label.patch3.23 KBDeFr

Comments

Grimreaper created an issue. See original summary.

DeFr’s picture

DeFr commented
Status: Active » Needs review
StatusFileSize
new 2805257-2-taxonomy-term-label.patch3.23 KB

Attached patch pass the whole EntityTypeInterface down to the EntitySyncWrapper instead of only the entity_type id, which allows EntitySyncWrapper to inspect the correct key to use.

DeFr’s picture

DeFr commented

Note: this patch applies on top of the one found in #2805261: Fatal error when trying to import taxonomy term

  • DeFr authored 60da6c7 on 8.x-1.x 
    Issue #2805257 by DeFr, Grimreaper: Label incorrect if entity label...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Fixed

Doing a manual test: OK.

I changed two php docs:

   * @var Drupal\Core\Entity\EntityTypeInterface

by

   * @var \Drupal\Core\Entity\EntityTypeInterface

missing an anti-slash.

Thanks for the patch it is now merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.