The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
In #2801889: Parameter "filter" for route "diff.revisions_diff" must match... crash we fixed an update function that didn't enable any plugin which lead to an exception.
Proposed resolution
Validate the form to prevent any layout to be enabled.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | test_coverage-2805249-7.patch | 871 bytes | ModernMantra |
| #2 | validate_layout_plugins-2805249-2.patch | 819 bytes | johnchque |
Comments
Comment #2
johnchqueComment #3
johnchqueThis should make it better.
Comment #4
dhendriks commentedI don't know much about PHP, but wouldn't using a Boolean variable be cheaper than using an array? And you can break the loop as soon as you find an enabled layout plugin, right?
Comment #5
miro_dietikerCommitted, with some comment added.
Still back to needs work to provide test coverage...
Comment #7
ModernMantra commentedAdding test coverage :)
Comment #8
dhendriks commentedA question about the test from #7: why do you only need to disable the 'unified fields' and 'split fields' layout plugins, and not the 'Visual Inline' layout plugin?
Comment #9
dhendriks commentedI see the code patch is already committed (see #5 and #6). Was my comment (see #4) considered?
Comment #10
miro_dietikerBecause the visual plugin is technically initially disabled by default and is not enabled because the library doesn't exist on test bot.
Committed. :-)