Add tests to make sure everything works as intended.

CommentFileSizeAuthor
#14 panels_everywhere-n2804901-14.patch19.82 KBdamienmckenna
#8 panels_everywhere-n2804901-8.patch19.81 KBdamienmckenna
#2 panels_everywhere-n2804901-2.patch6.08 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new panels_everywhere-n2804901-2.patch6.08 KB

Plotting out some skeleton files.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: panels_everywhere-n2804901-2.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2804977: Panels Everywhere tests failing with "too may arguments"

Something's wrong with the testrunner, so I opened an issue about it: #2804977: Panels Everywhere tests failing with "too may arguments"

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #1816558: Plan for Panels_Everywhere 7.x-1.0 release
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new panels_everywhere-n2804901-8.patch19.81 KB

Now adding actual tests.

Status: Needs review » Needs work

The last submitted patch, 8: panels_everywhere-n2804901-8.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: panels_everywhere-n2804901-8.patch, failed testing.

The last submitted patch, 8: panels_everywhere-n2804901-8.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

All of the tests pass locally. Darnit.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new panels_everywhere-n2804901-14.patch19.82 KB

Ah, I had a PHP5.4-ism with short array syntax. Doh.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The PHP 5.6 and PHP 7 tests might have passed if I'd pushed up the code changes that were sitting on my local checkout. Doh.

Status: Needs review » Needs work

The last submitted patch, 14: panels_everywhere-n2804901-14.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

  • DamienMcKenna committed 46bc412 on 7.x-1.x 
    Issue #2804901 by DamienMcKenna: Added some initial tests.
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.