As this l method \Drupal::l going to be deprecated , please replace this from the code base.

CommentFileSizeAuthor
#11 removed_deprecated-2803661-11.patch32.13 KBtduong
#11 interdiff-2803661-8-11.txt21.98 KBtduong
#8 removed_deprecated-2803661-8.patch23.52 KBginovski
#4 removed_deprecated-2803661-4.patch24.28 KBginovski
#4 interdiff-2803661-2-4.txt23.02 KBginovski
#2 removed_deprecated_method_l-2803661-2.patch1.41 KBPradnya Pingat

Comments

Pradnya Pingat created an issue. See original summary.

Pradnya Pingat’s picture

Pradnya Pingat commented
Assigned: Pradnya Pingat » Unassigned
Status: Active » Needs review
StatusFileSize
new removed_deprecated_method_l-2803661-2.patch1.41 KB

Patch Added.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Title: Removed deprecated method l from code base » Removed deprecated method calls from code base
Status: Needs review » Needs work

Yeah agree, but we like to do non-functional clean ups in a combined patch.

So this issue would need to be more general, such as covering all/most deprecated calls.
From quickly checking phpcs with PHPStorm, i see there are more than 30 other deprecated calls.

ginovski’s picture

ginovski commented
Assigned: Unassigned » ginovski
Status: Needs work » Needs review
StatusFileSize
new interdiff-2803661-2-4.txt23.02 KB
new removed_deprecated-2803661-4.patch24.28 KB

Removed all deprecated methods, only 1 left (entityManager->getViewModes(), there is still no replacement for this 1).

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs review » Needs work 
+++ b/src/Plugin/diff/Layout/SplitFieldsDiffLayout.php
@@ -80,7 +80,7 @@ class SplitFieldsDiffLayout extends DiffLayoutBase {
-      $container->get('entity.manager'),
+      $container->get('entity_type.manager'),

If you gonna change this, you should also change the variable name that is set in __construct

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs work » Reviewed & tested by the community

Actually those changes were made.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -drupal8

Needs a reroll after other commits.

ginovski’s picture

ginovski commented
Status: Needs work » Needs review
StatusFileSize
new removed_deprecated-2803661-8.patch23.52 KB

Rerolled

Status: Needs review » Needs work

The last submitted patch, 8: removed_deprecated-2803661-8.patch, failed testing.

tduong’s picture

tduong commented
Assigned: ginovski » tduong

Ginovski is off, taking over this issue.

tduong’s picture

tduong commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2803661-8-11.txt21.98 KB
new removed_deprecated-2803661-11.patch32.13 KB

Changed some construct variable name convetion, fixed some Link imports, improved a bit the test about some repeating code, and tried to remove some unrelated changes I made.

johnchque’s picture

johnchque
Primary language Spanish
Location Bolivia
commented
Status: Needs review » Reviewed & tested by the community

Thank you. :)

  • miro_dietiker committed 3248f13 on 8.x-1.x authored by tduong 
    Issue #2803661 by Ginovski, tduong: Removed deprecated method calls from...
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Great, committing to avoid further rerolls and conflicts with other commits...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.