Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In Drupal 8, the inline images are not displayed when template debugging is enabled. because debugging mode outputs additional information in HTML comments.
In FilterImageStyle.php
, only the first node of the rendered image is inserted in the output. By inserting all nodes, the debugging problem is solved and coincidentally, the plugin also works with templates in which multiple nodes are used. I propose the attached patch to solve this problem.
Comment | File | Size | Author |
---|---|---|---|
#6 | issue-2802013-6.patch | 3.53 KB | keithm |
Comments
Comment #2
erik CreditAttribution: erik commentedThis is great Emiel, thanks a lot for this patch!
Hope it will be incorporated soon..
Comment #3
Jon@s CreditAttribution: Jon@s commentedCan confirm this patch worked for me with 8.x-2.0 (June 06 2016) and Drupal 8.2.1
Note: I had to apply the patch by hand (no big deal only a few lines) for some reason.
Comment #4
afoster CreditAttribution: afoster commentedConfirming the patch resolved the issue with Twig Debugging. Updating status to reviewed (Hopefully this is OK?)
Patch applied to the newest Inline Responsive images 2.x-dev (Oct 20, 2016) in a site running Drupal 8.2.1
Also to note I've running patch from https://www.drupal.org/node/2816745 which allows the UI to work in D8.2.1 - Both patches play nicely together.
Comment #5
profak CreditAttribution: profak as a volunteer commented+1 for patch in this issue. @jeroen_betawerk, please commit to 2.x-dev!
Comment #6
keithm CreditAttribution: keithm commentedRerolled patch to apply cleanly with 'git apply'. The problem Jon@s had in #3 may have been caused by a mixture of line Unix and DOS/Windows endings in the patch, as well as a mixture of line endings in this module itself.
This patch requires the patch from #2865861: Use Unix line endings in code (which corrects the code to use the Drupal standard Unix endings) to be applied first.
Comment #8
keithm CreditAttribution: keithm commentedThis is fixed.
@emielbeinema thanks for investigating and patching.